WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
190989
Web Inspector: refactor code for getting properties via WI.RemoteObject
https://bugs.webkit.org/show_bug.cgi?id=190989
Summary
Web Inspector: refactor code for getting properties via WI.RemoteObject
Devin Rousso
Reported
2018-10-27 11:01:07 PDT
Provide a way for callers to retrieve properties on a `WI.RemoteObject` without generating a preview. Additionally, centralize all the different functions into one main pathway.
Attachments
Patch
(16.43 KB, patch)
2018-10-27 11:05 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(16.47 KB, patch)
2018-10-27 11:11 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2018-10-27 11:05:14 PDT
Created
attachment 353239
[details]
Patch
EWS Watchlist
Comment 2
2018-10-27 11:09:13 PDT
Comment hidden (obsolete)
Attachment 353239
[details]
did not pass style-queue: ERROR: Source/WebInspectorUI/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] ERROR: LayoutTests/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Devin Rousso
Comment 3
2018-10-27 11:11:41 PDT
Created
attachment 353243
[details]
Patch Whoops. Forgot bug number.
Matt Baker
Comment 4
2018-10-29 16:04:20 PDT
Comment on
attachment 353243
[details]
Patch r=me
WebKit Commit Bot
Comment 5
2018-10-29 16:29:21 PDT
Comment on
attachment 353243
[details]
Patch Clearing flags on attachment: 353243 Committed
r237571
: <
https://trac.webkit.org/changeset/237571
>
WebKit Commit Bot
Comment 6
2018-10-29 16:29:23 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7
2018-10-29 16:30:45 PDT
<
rdar://problem/45654001
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug