Bug 190989 - Web Inspector: refactor code for getting properties via WI.RemoteObject
Summary: Web Inspector: refactor code for getting properties via WI.RemoteObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks: WebInspectorAuditTab
  Show dependency tree / graph
 
Reported: 2018-10-27 11:01 PDT by Devin Rousso
Modified: 2018-10-29 16:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (16.43 KB, patch)
2018-10-27 11:05 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Patch (16.47 KB, patch)
2018-10-27 11:11 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-27 11:01:07 PDT 
Provide a way for callers to retrieve properties on a `WI.RemoteObject` without generating a preview.  Additionally, centralize all the different functions into one main pathway.
Comment 1 Devin Rousso 2018-10-27 11:05:14 PDT 
Created attachment 353239 [details]
Patch
Comment 2 EWS Watchlist 2018-10-27 11:09:13 PDT Comment hidden (obsolete)
Comment 3 Devin Rousso 2018-10-27 11:11:41 PDT 
Created attachment 353243 [details]
Patch

Whoops.  Forgot bug number.
Comment 4 Matt Baker 2018-10-29 16:04:20 PDT 
Comment on attachment 353243 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2018-10-29 16:29:21 PDT 
Comment on attachment 353243 [details]
Patch

Clearing flags on attachment: 353243

Committed r237571: <https://trac.webkit.org/changeset/237571>
Comment 6 WebKit Commit Bot 2018-10-29 16:29:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2018-10-29 16:30:45 PDT 
<rdar://problem/45654001>