Bug 190987 – Web Inspector: provide options to WI.cssPath for more verbosity

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

This will let us be more verbose in logging.

[Devin Rousso]

Created attachment 353237 [details]
Patch

[EWS Watchlist]

Attachment 353237 [details] did not pass style-queue:


ERROR: Source/WebInspectorUI/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
ERROR: LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Devin Rousso]

Created attachment 353241 [details]
Patch

Whoops.  Forgot bug number.

[Devin Rousso]

Created attachment 353345 [details]
Patch

[Blaze Burg]

Comment on attachment 353345 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353345&action=review

r=me

> Source/WebInspectorUI/ChangeLog:8
> +        * UserInterface/Base/DOMUtilities.js:

You need to describe the enhancements being made here.

> Source/WebInspectorUI/UserInterface/Base/DOMUtilities.js:138
> +            let unique = new Map;

Nit: uniqueAttributes

> LayoutTests/inspector/dom/domutilities-csspath.html:10
> +    async function nodeForSelector(selector) {

v.nice!

[Devin Rousso]

Created attachment 353409 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 353409 [details]
Patch

Clearing flags on attachment: 353409

Committed r237608: <https://trac.webkit.org/changeset/237608>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45684504>