This will allow options to be added in the future without having to supply falsy arguments.
Created attachment 353238 [details] Patch
Attachment 353238 [details] did not pass style-queue: ERROR: Source/WebInspectorUI/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 353242 [details] Patch Whoops. Forgot bug number.
Comment on attachment 353242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353242&action=review r=me > Source/WebInspectorUI/ChangeLog:8 > + * UserInterface/Views/ScopeBarItem.js: You didn't say what the better extensibility is. > Source/WebInspectorUI/UserInterface/Views/LogContentView.js:82 > + new WI.ScopeBarItem(WI.LogContentView.Scopes.Debugs, WI.UIString("Debugs"), {className: "debugs", hidden: true}), Yaaassss > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:58 > + exclusive: true, Nit: No need to wrap this line > Source/WebInspectorUI/UserInterface/Views/ScopeBar.js:-155 > - var replacesCurrentSelection = this._shouldGroupNonExclusiveItems || !event.data.withModifier; Nit: let > Source/WebInspectorUI/UserInterface/Views/ScopeBar.js:157 > + var replacesCurrentSelection = this._shouldGroupNonExclusiveItems || !event.data.extendSelection; You should mention this renaming in the changelog. I thought it was a mistake.
Created attachment 353379 [details] Patch
Comment on attachment 353379 [details] Patch Clearing flags on attachment: 353379 Committed r237593: <https://trac.webkit.org/changeset/237593>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45673205>