Bug 190970 - Web Inspector: simplify some editing code checks
Summary: Web Inspector: simplify some editing code checks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-26 11:57 PDT by Devin Rousso
Modified: 2018-10-26 14:04 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.21 KB, patch)
2018-10-26 12:03 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-26 11:57:43 PDT 
There's no need to check each parent for the "CodeMirror" class when `CodeMirror` gets added as an expando property on the element itself.
Comment 1 Devin Rousso 2018-10-26 12:03:17 PDT 
Created attachment 353197 [details]
Patch
Comment 2 Joseph Pecoraro 2018-10-26 13:34:55 PDT 
Comment on attachment 353197 [details]
Patch

r=me, be on the look-out if any issues pop up since this has been some traditionally tricky code, but this looks good to me and I don't expect any fallout.
Comment 3 WebKit Commit Bot 2018-10-26 14:03:57 PDT 
Comment on attachment 353197 [details]
Patch

Clearing flags on attachment: 353197

Committed r237482: <https://trac.webkit.org/changeset/237482>
Comment 4 WebKit Commit Bot 2018-10-26 14:03:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-10-26 14:04:26 PDT 
<rdar://problem/45598701>