RESOLVED FIXED190970
Web Inspector: simplify some editing code checks 
https://bugs.webkit.org/show_bug.cgi?id=190970
Summary Web Inspector: simplify some editing code checks
Devin Rousso
Reported 2018-10-26 11:57:43 PDT
There's no need to check each parent for the "CodeMirror" class when `CodeMirror` gets added as an expando property on the element itself.
Attachments
Patch (6.21 KB, patch)
2018-10-26 12:03 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-10-26 12:03:17 PDT
Created attachment 353197 [details] Patch
Joseph Pecoraro
Comment 2 2018-10-26 13:34:55 PDT
Comment on attachment 353197 [details] Patch r=me, be on the look-out if any issues pop up since this has been some traditionally tricky code, but this looks good to me and I don't expect any fallout.
WebKit Commit Bot
Comment 3 2018-10-26 14:03:57 PDT
Comment on attachment 353197 [details] Patch Clearing flags on attachment: 353197 Committed r237482: <https://trac.webkit.org/changeset/237482>
WebKit Commit Bot
Comment 4 2018-10-26 14:03:58 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2018-10-26 14:04:26 PDT
<rdar://problem/45598701>
Note You need to log in before you can comment on or make changes to this bug.