Bug 190952 - JSC xcconfig should set DEFINES_MODULE
Summary: JSC xcconfig should set DEFINES_MODULE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-26 05:01 PDT by Keith Miller
Modified: 2018-10-26 09:48 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.21 KB, patch)
2018-10-26 05:10 PDT, Keith Miller
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-10-26 05:01:38 PDT
JSC xcconfig should set DEFINES_MODULE
Comment 1 Keith Miller 2018-10-26 05:10:31 PDT
Created attachment 353175 [details]
Patch
Comment 2 Keith Miller 2018-10-26 09:41:09 PDT
rdar://problem/45169447
Comment 3 Mark Lam 2018-10-26 09:41:57 PDT
Comment on attachment 353175 [details]
Patch

rs=me
Comment 4 Keith Miller 2018-10-26 09:48:11 PDT
Committed r237462: <https://trac.webkit.org/changeset/237462>