Bug 190951 – Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI

[Jer Noble]

<rdar://problem/45213065>

[Jer Noble]

Created attachment 353172 [details]
Patch

[Jer Noble]

Created attachment 353173 [details]
Patch

[Jer Noble]

Created attachment 353174 [details]
Patch

[Alex Christensen]

Comment on attachment 353174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353174&action=review

> Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.messages.in:38
> +    RequestRouteSharingPolicyAndContextUID(uint64_t contextId) -> (enum:uint8_t WebCore::RouteSharingPolicy routeSharingPolicy, String routingContextUID) Async

This message is never sent.  You need to add a call to Connection::sendWithAsyncReply somewhere.
This is also dependent on https://trac.webkit.org/changeset/237294/webkit

[Jer Noble]

Created attachment 353179 [details]
Patch

[Jer Noble]

Created attachment 353181 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 353181 [details]
Patch

Clearing flags on attachment: 353181

Committed r237458: <https://trac.webkit.org/changeset/237458>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 190973

[Jer Noble]

Created attachment 353296 [details]
Patch

[Jon Lee]

Can we land this now?

[Jer Noble]

Created attachment 355644 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 355644 [details]
Patch for landing

Rejecting attachment 355644 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 355644, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355644&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=190951&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 355644 from bug 190951.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355644
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 16 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/PAL/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h
patching file Source/WebCore/platform/cocoa/VideoFullscreenModel.h
patching file Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h
patching file Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm
patching file Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h
patching file Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
Hunk #4 succeeded at 1248 (offset 3 lines).
patching file Source/WebKit/Platform/IPC/MessageSender.h
patching file Source/WebKit/Scripts/webkit/messages.py
Hunk #1 FAILED at 561.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Scripts/webkit/messages.py.rej
patching file Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
patching file Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
patching file Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h
patching file Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.messages.in
patching file Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10157864

[Jer Noble]

Created attachment 355670 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 355670 [details]
Patch for landing

Rejecting attachment 355670 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 355670, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/PAL/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/10159016

[Jer Noble]

Created attachment 355683 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 355683 [details]
Patch for landing

Clearing flags on attachment: 355683

Committed r238528: <https://trac.webkit.org/changeset/238528>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Jer Noble]

Committed r238556: <https://trac.webkit.org/changeset/238556>

[Jer Noble]

Committed r238560: <https://trac.webkit.org/changeset/238560>