Bug 190951 - Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI
Summary: Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on: 190973
Blocks:
  Show dependency tree / graph
 
Reported: 2018-10-26 03:38 PDT by Jer Noble
Modified: 2018-11-27 11:32 PST (History)
5 users (show)

See Also:

Attachments
Patch (17.28 KB, patch)
2018-10-26 03:43 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (17.31 KB, patch)
2018-10-26 03:46 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (17.81 KB, patch)
2018-10-26 04:35 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (19.92 KB, patch)
2018-10-26 06:16 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (20.89 KB, patch)
2018-10-26 06:54 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (21.65 KB, patch)
2018-10-29 10:17 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (20.87 KB, patch)
2018-11-26 09:46 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (19.13 KB, patch)
2018-11-26 13:41 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (19.13 KB, patch)
2018-11-26 15:23 PST, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (8) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-10-26 03:38:57 PDT 
Adopt -setOverrideRouteSharingPolicy:routingContextUID: SPI
Comment 1 Jer Noble 2018-10-26 03:39:43 PDT 
<rdar://problem/45213065>
Comment 2 Jer Noble 2018-10-26 03:43:19 PDT 
Created attachment 353172 [details]
Patch
Comment 3 Jer Noble 2018-10-26 03:46:26 PDT 
Created attachment 353173 [details]
Patch
Comment 4 Jer Noble 2018-10-26 04:35:48 PDT 
Created attachment 353174 [details]
Patch
Comment 5 Alex Christensen 2018-10-26 05:41:02 PDT 
Comment on attachment 353174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353174&action=review

> Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.messages.in:38
> +    RequestRouteSharingPolicyAndContextUID(uint64_t contextId) -> (enum:uint8_t WebCore::RouteSharingPolicy routeSharingPolicy, String routingContextUID) Async

This message is never sent.  You need to add a call to Connection::sendWithAsyncReply somewhere.
This is also dependent on https://trac.webkit.org/changeset/237294/webkit
Comment 6 Jer Noble 2018-10-26 06:16:02 PDT 
Created attachment 353179 [details]
Patch
Comment 7 Jer Noble 2018-10-26 06:54:21 PDT 
Created attachment 353181 [details]
Patch
Comment 8 WebKit Commit Bot 2018-10-26 08:04:54 PDT 
Comment on attachment 353181 [details]
Patch

Clearing flags on attachment: 353181

Committed r237458: <https://trac.webkit.org/changeset/237458>
Comment 9 WebKit Commit Bot 2018-10-26 08:04:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 10 WebKit Commit Bot 2018-10-26 14:30:48 PDT 
Re-opened since this is blocked by bug 190973
Comment 11 Jer Noble 2018-10-29 10:17:26 PDT 
Created attachment 353296 [details]
Patch
Comment 12 Jon Lee 2018-11-08 18:46:15 PST 
Can we land this now?
Comment 13 Jer Noble 2018-11-26 09:46:18 PST 
Created attachment 355644 [details]
Patch for landing
Comment 14 WebKit Commit Bot 2018-11-26 13:20:33 PST 
Comment on attachment 355644 [details]
Patch for landing

Rejecting attachment 355644 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 355644, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as commit-queue@webkit.org...
Fetching: https://bugs.webkit.org/attachment.cgi?id=355644&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=190951&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 355644 from bug 190951.
Fetching: https://bugs.webkit.org/attachment.cgi?id=355644
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 16 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/PAL/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h
patching file Source/WebCore/platform/cocoa/VideoFullscreenModel.h
patching file Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.h
patching file Source/WebCore/platform/cocoa/VideoFullscreenModelVideoElement.mm
patching file Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h
patching file Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm
Hunk #4 succeeded at 1248 (offset 3 lines).
patching file Source/WebKit/Platform/IPC/MessageSender.h
patching file Source/WebKit/Scripts/webkit/messages.py
Hunk #1 FAILED at 561.
1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/Scripts/webkit/messages.py.rej
patching file Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.h
patching file Source/WebKit/UIProcess/Cocoa/VideoFullscreenManagerProxy.mm
patching file Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.h
patching file Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.messages.in
patching file Source/WebKit/WebProcess/cocoa/VideoFullscreenManager.mm

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/10157864
Comment 15 Jer Noble 2018-11-26 13:41:12 PST 
Created attachment 355670 [details]
Patch for landing
Comment 16 WebKit Commit Bot 2018-11-26 15:04:43 PST 
Comment on attachment 355670 [details]
Patch for landing

Rejecting attachment 355670 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 355670, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/WebCore/PAL/ChangeLog contains OOPS!.

Full output: https://webkit-queues.webkit.org/results/10159016
Comment 17 Jer Noble 2018-11-26 15:23:53 PST 
Created attachment 355683 [details]
Patch for landing
Comment 18 WebKit Commit Bot 2018-11-26 16:02:35 PST 
Comment on attachment 355683 [details]
Patch for landing

Clearing flags on attachment: 355683

Committed r238528: <https://trac.webkit.org/changeset/238528>
Comment 19 WebKit Commit Bot 2018-11-26 16:02:37 PST 
All reviewed patches have been landed.  Closing bug.
Comment 20 Jer Noble 2018-11-27 09:28:54 PST 
Committed r238556: <https://trac.webkit.org/changeset/238556>
Comment 21 Jer Noble 2018-11-27 11:32:04 PST 
Committed r238560: <https://trac.webkit.org/changeset/238560>