Bug 190931 – Modernize / Simplify IPC::Connection::sendOutgoingMessage()

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

Modernize / Simplify IPC::Connection::sendOutgoingMessage().

[Chris Dumez]

Created attachment 353129 [details]
Patch

[EWS Watchlist]

Attachment 353129 [details] did not pass style-queue:


ERROR: Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:302:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Alex Christensen]

Comment on attachment 353129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353129&action=review

> Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:-334
> -        header->msgh_id |= MessageBodyIsOutOfLine;

Did this do nothing?

[Chris Dumez]

(In reply to Alex Christensen from comment #3)
> Comment on attachment 353129 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=353129&action=review
> 
> > Source/WebKit/Platform/IPC/mac/ConnectionMac.mm:-334
> > -        header->msgh_id |= MessageBodyIsOutOfLine;
> 
> Did this do nothing?

I merely moved it below.

[Alex Christensen]

Comment on attachment 353129 [details]
Patch

Sure enough.

[WebKit Commit Bot]

Comment on attachment 353129 [details]
Patch

Clearing flags on attachment: 353129

Committed r237460: <https://trac.webkit.org/changeset/237460>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45588328>