Bug 190928 - [LFC][IFC] Find floating constraints for a given vertical position
Summary: [LFC][IFC] Find floating constraints for a given vertical position
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-25 16:19 PDT by zalan
Modified: 2018-10-26 07:30 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.25 KB, patch)
2018-10-25 16:26 PDT, zalan 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2018-10-25 16:19:38 PDT 
ssia.
Comment 1 zalan 2018-10-25 16:26:57 PDT 
Created attachment 353128 [details]
Patch
Comment 2 EWS Watchlist 2018-10-26 07:23:57 PDT 
Attachment 353128 [details] did not pass style-queue:


ERROR: Source/WebCore/layout/floats/FloatingState.cpp:126:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/layout/floats/FloatingState.cpp:132:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 zalan 2018-10-26 07:29:29 PDT 
Committed r237452: <https://trac.webkit.org/changeset/237452>
Comment 4 Radar WebKit Bug Importer 2018-10-26 07:30:51 PDT 
<rdar://problem/45586923>