Bug 190926 – Add rudimentary `console` support to jsc for use when inspecting jsc

• Status: NEW
• Component: JavaScriptCore

[Joseph Pecoraro]

Add rudimentary `console` support to jsc for use when inspecting jsc

Currently:

    $ jsc
    >>> console.log("test")
    Exception: TypeError: undefined is not an object (evaluating 'console.log')

Expected something like:

    $ jsc --enable-console
    >>> console.log('test')
    CONSOLE LOG test
    undefined

It is rudimentary, just using our currently Log to System Console support, not node.js like `console` support. But when a JSContext Inspector is attached (jsc --remote-debug) this allows for full `console` support).

[Joseph Pecoraro]

Created attachment 353123 [details]
[PATCH] Proposed Fix

[Dean Jackson]

My comment to Joe was that we shouldn't prefix output with "CONSOLE LOG" because it makes it difficult to use jsc as a generation tool.

He disagreed, suggesting that node is the right solution for that.

[Joseph Pecoraro]

(In reply to Dean Jackson from comment #2)
> My comment to Joe was that we shouldn't prefix output with "CONSOLE LOG"
> because it makes it difficult to use jsc as a generation tool.
> 
> He disagreed, suggesting that node is the right solution for that.

I do agree we could improve on console.log's formatting. But enabling it like this is simple and makes it work completely in remote inspection, which was my goal with this change.

[Keith Miller]

Comment on attachment 353123 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=353123&action=review

> Source/JavaScriptCore/jsc.cpp:2669
> +        if (!strcmp(arg, "--enable-console")) {

Should we also enable this by default if you pass "--remote-debug"?

[Dean Jackson]

Comment on attachment 353123 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=353123&action=review

>> Source/JavaScriptCore/jsc.cpp:2669
>> +        if (!strcmp(arg, "--enable-console")) {
> 
> Should we also enable this by default if you pass "--remote-debug"?

Yes! Good idea.