Bug 190901 – [Web Animations] Turn Web Animations CSS Integration off by default

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Quint]

[Web Animations] Turn Web Animations CSS Integration off by default

[Antoine Quint]

Created attachment 353086 [details]
Patch

[Don Olmstead]

Informal r+. 

The WinCairo EWS is red because of https://bugs.webkit.org/show_bug.cgi?id=187725 which hopefully should be landing soon.

[EWS Watchlist]

Comment on attachment 353086 [details]
Patch

Attachment 353086 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9726320

New failing tests:
http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html

[EWS Watchlist]

Created attachment 353091 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Antoine Quint]

Committed r237421: <https://trac.webkit.org/changeset/237421>

[Radar WebKit Bug Importer]

<rdar://problem/45562620>

[Ryan Haddad]

(In reply to Build Bot from comment #3)
> Comment on attachment 353086 [details]
> Patch
> 
> Attachment 353086 [details] did not pass mac-debug-ews (mac):
> Output: https://webkit-queues.webkit.org/results/9726320
> 
> New failing tests:
> http/tests/inspector/network/resource-response-source-memory-cache-
> revalidate-expired-only.html
This is crashing on the bots now that this change has been landed.

ASSERTION FAILED: !frame().animation().hasAnimations()
./page/FrameView.cpp(607) : void WebCore::FrameView::didDestroyRenderTree()

https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r237421%20(342)/results.html

[Antoine Quint]

The crash can be reproduced by running this command:

run-webkit-tests -1 --debug --child-processes=1 http/tests/inspector/network/resource-initiatorNode.html http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html

[Antoine Quint]

The reason this is happening is that RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsCSSIntegrationEnabled() is called under -[WebInspectorWindowController init:] with a value of false whereas this should always be true.

[Antoine Quint]

The inspector test crash is tracked by https://bugs.webkit.org/show_bug.cgi?id=190955.