Bug 190901 - [Web Animations] Turn Web Animations CSS Integration off by default
Summary: [Web Animations] Turn Web Animations CSS Integration off by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-25 08:18 PDT by Antoine Quint
Modified: 2018-10-26 05:49 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.71 KB, patch)
2018-10-25 08:19 PDT, Antoine Quint 		dino: review+
ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-sierra (3.06 MB, application/zip)
2018-10-25 10:26 PDT, EWS Watchlist 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2018-10-25 08:18:44 PDT 
[Web Animations] Turn Web Animations CSS Integration off by default
Comment 1 Antoine Quint 2018-10-25 08:19:31 PDT 
Created attachment 353086 [details]
Patch
Comment 2 Don Olmstead 2018-10-25 09:08:47 PDT 
Informal r+. 

The WinCairo EWS is red because of https://bugs.webkit.org/show_bug.cgi?id=187725 which hopefully should be landing soon.
Comment 3 EWS Watchlist 2018-10-25 10:26:00 PDT 
Comment on attachment 353086 [details]
Patch

Attachment 353086 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9726320

New failing tests:
http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html
Comment 4 EWS Watchlist 2018-10-25 10:26:02 PDT 
Created attachment 353091 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6
Comment 5 Antoine Quint 2018-10-25 12:17:12 PDT 
Committed r237421: <https://trac.webkit.org/changeset/237421>
Comment 6 Radar WebKit Bug Importer 2018-10-25 12:18:34 PDT 
<rdar://problem/45562620>
Comment 7 Ryan Haddad 2018-10-25 16:59:18 PDT 
(In reply to Build Bot from comment #3)
> Comment on attachment 353086 [details]
> Patch
> 
> Attachment 353086 [details] did not pass mac-debug-ews (mac):
> Output: https://webkit-queues.webkit.org/results/9726320
> 
> New failing tests:
> http/tests/inspector/network/resource-response-source-memory-cache-
> revalidate-expired-only.html
This is crashing on the bots now that this change has been landed.

ASSERTION FAILED: !frame().animation().hasAnimations()
./page/FrameView.cpp(607) : void WebCore::FrameView::didDestroyRenderTree()

https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r237421%20(342)/results.html
Comment 8 Antoine Quint 2018-10-26 01:59:37 PDT 
The crash can be reproduced by running this command:

run-webkit-tests -1 --debug --child-processes=1 http/tests/inspector/network/resource-initiatorNode.html http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html
Comment 9 Antoine Quint 2018-10-26 04:53:28 PDT 
The reason this is happening is that RuntimeEnabledFeatures::sharedFeatures().setWebAnimationsCSSIntegrationEnabled() is called under -[WebInspectorWindowController init:] with a value of false whereas this should always be true.
Comment 10 Antoine Quint 2018-10-26 05:49:28 PDT 
The inspector test crash is tracked by https://bugs.webkit.org/show_bug.cgi?id=190955.