Bug 190897 - REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewController times out
Summary: REGRESSION (r237331): DismissingActionSheetShouldNotDismissPresentingViewCont...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-24 23:11 PDT by Tim Horton
Modified: 2018-10-25 09:43 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-10-24 23:11:44 PDT
This test is timing out because it's trying to simulate a long press on a unparented WKWebView.

After r237331, you can't interact with an unparented WKWebView via gesture recognizers.

It's extremely unclear why presenting the TestWKWebViewController on the root view controller in the navigation controller doesn't parent it, but it doesn't; the view hierarchy stops at the root view controller's view.

I'm going to disable the test for now since this is clearly a test infrastructure problem, and I'll enlist Wenson's help to repair it.
Comment 1 Tim Horton 2018-10-24 23:13:03 PDT
Test disabled in https://trac.webkit.org/changeset/237407/webkit
Comment 2 Wenson Hsieh 2018-10-24 23:19:10 PDT
(In reply to Tim Horton from comment #0)
> This test is timing out because it's trying to simulate a long press on a
> unparented WKWebView.
> 
> After r237331, you can't interact with an unparented WKWebView via gesture
> recognizers.
> 
> It's extremely unclear why presenting the TestWKWebViewController on the
> root view controller in the navigation controller doesn't parent it, but it
> doesn't; the view hierarchy stops at the root view controller's view.

Strange indeed. I wonder if this is due to TestWebKitAPI not being a UI application...

> 
> I'm going to disable the test for now since this is clearly a test
> infrastructure problem, and I'll enlist Wenson's help to repair it.