Bug 190896 - Web Inspector: Add a watchlist message rule to warn about feature checking new inspector protocol changes
Summary: Web Inspector: Add a watchlist message rule to warn about feature checking ne...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-24 19:18 PDT by Joseph Pecoraro
Modified: 2018-10-25 12:52 PDT (History)
7 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.69 KB, patch)
2018-10-24 19:19 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2018-10-24 19:18:42 PDT 
Add a watchlist message rule to warn about feature checking new inspector protocol changes

So if someone adds:

    Page.newFeature

We can add a comment that says "make sure to feature check new protocol APIs in the frontend".
Comment 1 Joseph Pecoraro 2018-10-24 19:19:31 PDT 
Created attachment 353071 [details]
[PATCH] Proposed Fix
Comment 2 Matt Baker 2018-10-25 12:27:08 PDT 
Comment on attachment 353071 [details]
[PATCH] Proposed Fix

r=me
Comment 3 WebKit Commit Bot 2018-10-25 12:51:50 PDT 
Comment on attachment 353071 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 353071

Committed r237422: <https://trac.webkit.org/changeset/237422>
Comment 4 WebKit Commit Bot 2018-10-25 12:51:51 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2018-10-25 12:52:39 PDT 
<rdar://problem/45563601>