Bug 190894 – InspectorCanvas is not getting cleared properly for OffscreenCanvas

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

InspectorCanvas is not getting cleared properly for OffscreenCanvas

    $ run-webkit-tests http/wpt/offscreen-canvas --release --dump-render-tree --guard-malloc --time-out-ms=10000 --iterations=10 --verbose --exit-after-n-failures=1
    …
    [1/40] http/wpt/offscreen-canvas/getContext-webgl.html passed
    [2/40] http/wpt/offscreen-canvas/offscreencanvas.constructor.html passed
    [3/40] http/wpt/offscreen-canvas/transferToImageBitmap-empty.html passed
    [4/40] http/wpt/offscreen-canvas/transferToImageBitmap-webgl.html failed unexpectedly (DumpRenderTree crashed [pid=10060])
    Exiting early after 1 failures. 4 tests run.

Crash:

    Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
    0 WebCore::InspectorCanvasAgent::clearCanvasData() + 108
    1 WebCore::InspectorInstrumentation::didCommitLoadImpl(WebCore::InstrumentingAgents&, WebCore::Frame&, WebCore::DocumentLoader*) + 217
    2 WebCore::FrameLoader::dispatchDidCommitLoad(std::optional<WebCore::HasInsecureContent>) + 120
    3 WebCore::FrameLoader::receivedFirstData() + 35
    4 WebCore::DocumentLoader::commitData(char const*, unsigned long) + 2274

[Joseph Pecoraro]

<rdar://problem/45498435>

[Joseph Pecoraro]

Created attachment 353070 [details]
[PATCH] Proposed Fix

[Radar WebKit Bug Importer]

<rdar://problem/45541593>

[EWS Watchlist]

Comment on attachment 353070 [details]
[PATCH] Proposed Fix

Attachment 353070 [details] did not pass mac-debug-ews (mac):
Output: https://webkit-queues.webkit.org/results/9720095

Number of test failures exceeded the failure limit.

[EWS Watchlist]

Created attachment 353073 [details]
Archive of layout-test-results from ews113 for mac-sierra

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-sierra  Platform: Mac OS X 10.12.6

[Joseph Pecoraro]

Created attachment 353074 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 353075 [details]
[PATCH] Proposed Fix

One of the ASSERTs was invalid since a context might never have been created. Retrying without that one assert.

[WebKit Commit Bot]

Comment on attachment 353075 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 353075

Committed r237409: <https://trac.webkit.org/changeset/237409>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.