Bug 19089 - Editing ASSERT in Range::compareBoundaryPoints
Summary: Editing ASSERT in Range::compareBoundaryPoints
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 18858
  Show dependency treegraph
 
Reported: 2008-05-15 14:53 PDT by Eric Seidel (no email)
Modified: 2008-06-05 17:22 PDT (History)
0 users

See Also:


Attachments
causes ASSERT in debug builds (462 bytes, text/html)
2008-05-15 14:53 PDT, Eric Seidel (no email)
no flags Details
patch (2.89 KB, patch)
2008-06-05 16:59 PDT, Justin Garcia
no flags Details | Formatted Diff | Diff
patch (3.46 KB, patch)
2008-06-05 17:03 PDT, Justin Garcia
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2008-05-15 14:53:13 PDT
Editing ASSERT in Range::compareBoundaryPoints

ASSERTION FAILED: containerA && containerB
(/Users/eseidel/Projects/WebKit/WebCore/dom/Range.cpp:458 static short int WebCore::Range::compareBoundaryPoints(WebCore::Node*, int, WebCore::Node*, int))

Found by the fuzzer.  See attached test case.

  doc.execCommand('inserthorizontalrule');
  doc.execCommand('formatblock', 0, '<pre>');
Comment 1 Eric Seidel (no email) 2008-05-15 14:53:37 PDT
Created attachment 21182 [details]
causes ASSERT in debug builds
Comment 2 Justin Garcia 2008-06-05 16:59:54 PDT
Created attachment 21514 [details]
patch
Comment 3 Justin Garcia 2008-06-05 17:03:50 PDT
Created attachment 21515 [details]
patch

Didn't include the meat of the patch last time.
Comment 4 Eric Seidel (no email) 2008-06-05 17:13:03 PDT
Comment on attachment 21515 [details]
patch

Looks good to me.  r+
Comment 5 Justin Garcia 2008-06-05 17:22:12 PDT
http://trac.webkit.org/changeset/34390