Bug 190885 - [High Sierra / Mojave Debug WK2] Layout Test media/video-restricted-invisible-autoplay-allowed-when-visible.html is a flaky failure
Summary: [High Sierra / Mojave Debug WK2] Layout Test media/video-restricted-invisible...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-24 11:37 PDT by Dawei Fenton (:realdawei)
Modified: 2019-06-12 17:02 PDT (History)
10 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2019-06-12 16:28 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dawei Fenton (:realdawei) 2018-10-24 11:37:15 PDT 
The following layout test is failing on [High Sierra Debug WK2]

media/video-restricted-invisible-autoplay-allowed-when-visible.html

Probable cause:

Unknown

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fvideo-restricted-invisible-autoplay-allowed-when-visible.html

--- /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/video-restricted-invisible-autoplay-allowed-when-visible-expected.txt
+++ /Volumes/Data/slave/highsierra-debug-tests-wk2/build/layout-test-results/media/video-restricted-invisible-autoplay-allowed-when-visible-actual.txt
@@ -3,6 +3,6 @@
 RUN(internals.setMediaElementRestrictions(video, "InvisibleAutoplayNotPermitted"))
 ** setting video.src
 RUN(document.body.appendChild(video))
-EVENT(play)
+FAIL: did not end fast enough
 END OF TEST
Comment 1 Ryan Haddad 2018-10-25 09:31:05 PDT 
I can repro the failures locally with:
media/video-restricted-invisible-autoplay-allowed-when-visible.html -fg --iter 100 --no-retry


I cannot repro the failure after making this change:

diff --git a/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html b/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html
index 50b7a1a7d88..a09825fb1a7 100644
--- a/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html
+++ b/LayoutTests/media/video-restricted-invisible-autoplay-allowed-when-visible.html
@@ -19,7 +19,7 @@
             function putInDOM()
             {
                 run('document.body.appendChild(video)');
-                failTestIn(250);
+                failTestIn(2000);
             }

             function play()
Comment 2 Radar WebKit Bug Importer 2018-10-26 09:54:59 PDT 
<rdar://problem/45590590>
Comment 3 Eric Carlson 2019-06-12 16:28:53 PDT 
Created attachment 371999 [details]
Patch
Comment 4 WebKit Commit Bot 2019-06-12 17:02:22 PDT 
Comment on attachment 371999 [details]
Patch

Clearing flags on attachment: 371999

Committed r246387: <https://trac.webkit.org/changeset/246387>
Comment 5 WebKit Commit Bot 2019-06-12 17:02:24 PDT 
All reviewed patches have been landed.  Closing bug.