Bug 190875 - Cure Windows Direct2D Backend of a nasty case of bitrot
Summary: Cure Windows Direct2D Backend of a nasty case of bitrot
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 191411
  Show dependency tree / graph
 
Reported: 2018-10-24 09:14 PDT by Brent Fulgham
Modified: 2018-11-07 19:51 PST (History)
9 users (show)

See Also:

Attachments
Patch (18.22 KB, patch)
2018-10-24 10:24 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (14.41 KB, patch)
2018-10-24 10:45 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (14.41 KB, patch)
2018-10-24 10:57 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (42.05 KB, patch)
2018-10-24 11:06 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2018-10-24 09:14:22 PDT 
You can't build for the Windows Direct2D backend right now. This patch corrects the build failures, and gets things working again.
Comment 1 Radar WebKit Bug Importer 2018-10-24 10:03:26 PDT 
<rdar://problem/45523268>
Comment 2 Brent Fulgham 2018-10-24 10:24:40 PDT 
Created attachment 353040 [details]
Patch
Comment 3 Brent Fulgham 2018-10-24 10:45:16 PDT 
Created attachment 353042 [details]
Patch
Comment 4 Brent Fulgham 2018-10-24 10:57:12 PDT 
Created attachment 353043 [details]
Patch
Comment 5 Brent Fulgham 2018-10-24 11:06:15 PDT 
Created attachment 353044 [details]
Patch
Comment 6 zalan 2018-10-24 11:20:26 PDT 
Comment on attachment 353044 [details]
Patch

rs=me
Comment 7 Don Olmstead 2018-10-24 11:22:23 PDT 
Informal r+

Are we going to need a buildbot for this going forward? I can see this getting out of sync quick if we don't keep up with this.
Comment 8 Brent Fulgham 2018-10-24 11:35:03 PDT 
(In reply to Don Olmstead from comment #7)
> Informal r+
> 
> Are we going to need a buildbot for this going forward? I can see this
> getting out of sync quick if we don't keep up with this.

Yes. Probably not until it's a bit more full-featured, but as soon as the obvious issues from simple manual browsing are addressed, a buildbot will be needed.
Comment 9 WebKit Commit Bot 2018-10-24 11:46:47 PDT 
Comment on attachment 353044 [details]
Patch

Clearing flags on attachment: 353044

Committed r237394: <https://trac.webkit.org/changeset/237394>
Comment 10 WebKit Commit Bot 2018-10-24 11:46:49 PDT 
All reviewed patches have been landed.  Closing bug.