WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
190875
Cure Windows Direct2D Backend of a nasty case of bitrot
https://bugs.webkit.org/show_bug.cgi?id=190875
Summary
Cure Windows Direct2D Backend of a nasty case of bitrot
Brent Fulgham
Reported
2018-10-24 09:14:22 PDT
You can't build for the Windows Direct2D backend right now. This patch corrects the build failures, and gets things working again.
Attachments
Patch
(18.22 KB, patch)
2018-10-24 10:24 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch
(14.41 KB, patch)
2018-10-24 10:45 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch
(14.41 KB, patch)
2018-10-24 10:57 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch
(42.05 KB, patch)
2018-10-24 11:06 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2018-10-24 10:03:26 PDT
<
rdar://problem/45523268
>
Brent Fulgham
Comment 2
2018-10-24 10:24:40 PDT
Created
attachment 353040
[details]
Patch
Brent Fulgham
Comment 3
2018-10-24 10:45:16 PDT
Created
attachment 353042
[details]
Patch
Brent Fulgham
Comment 4
2018-10-24 10:57:12 PDT
Created
attachment 353043
[details]
Patch
Brent Fulgham
Comment 5
2018-10-24 11:06:15 PDT
Created
attachment 353044
[details]
Patch
alan
Comment 6
2018-10-24 11:20:26 PDT
Comment on
attachment 353044
[details]
Patch rs=me
Don Olmstead
Comment 7
2018-10-24 11:22:23 PDT
Informal r+ Are we going to need a buildbot for this going forward? I can see this getting out of sync quick if we don't keep up with this.
Brent Fulgham
Comment 8
2018-10-24 11:35:03 PDT
(In reply to Don Olmstead from
comment #7
)
> Informal r+ > > Are we going to need a buildbot for this going forward? I can see this > getting out of sync quick if we don't keep up with this.
Yes. Probably not until it's a bit more full-featured, but as soon as the obvious issues from simple manual browsing are addressed, a buildbot will be needed.
WebKit Commit Bot
Comment 9
2018-10-24 11:46:47 PDT
Comment on
attachment 353044
[details]
Patch Clearing flags on attachment: 353044 Committed
r237394
: <
https://trac.webkit.org/changeset/237394
>
WebKit Commit Bot
Comment 10
2018-10-24 11:46:49 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug