RESOLVED FIXED 190867
[WPE][GTK] Cleanups to the certificate decoder 
https://bugs.webkit.org/show_bug.cgi?id=190867
Summary [WPE][GTK] Cleanups to the certificate decoder
Claudio Saavedra
Reported 2018-10-24 04:16:40 PDT
[WPE][GTK] Cleanups to the certificate decoder
Attachments
Patch (2.52 KB, patch)
2018-10-24 04:17 PDT, Claudio Saavedra 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Claudio Saavedra
Comment 1 2018-10-24 04:17:01 PDT
Created attachment 353031 [details] Patch
Claudio Saavedra
Comment 2 2018-10-24 06:45:36 PDT
Comment on attachment 353031 [details] Patch Clearing flags on attachment: 353031 Committed r237380: <https://trac.webkit.org/changeset/237380>
Claudio Saavedra
Comment 3 2018-10-24 06:45:40 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 4 2018-10-24 07:56:54 PDT
Comment on attachment 353031 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353031&action=review > Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp:103 > + GRefPtr<GByteArray> certificateData = g_byte_array_sized_new(certificateDataReference.size()); Now, because you did not use adotpGRef(), there are two refs to the GByteArray: the original one, and the GRefPtr's. > Source/WebKit/Shared/soup/WebCoreArgumentCodersSoup.cpp:104 > + certificateData = g_byte_array_append(certificateData.get(), certificateDataReference.data(), certificateDataReference.size()); So now the GRefPtr would drop its ref on the original GByteArray and ref the new one. But the original ref on the original GByteArray has been lost. Right? I think you need to use adoptGRef() on the line above.
Note You need to log in before you can comment on or make changes to this bug.