Bug 190859 – Web Inspector: popovers for function source code are malformed

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

Created attachment 353015 [details]
[Image] Screenshot of Issue

* STEPS TO REPRODUCE:
1. Go to any bug on <https://bugs.webkit.org> that has a Patch attachment
2. Click "Review Patch"
3. Open WebInspector
4. Go to the Debugger tab
5. Hit the "Pause script execution" button ( || )
6. Move the mouse onto the page (WebInspector should pause on jquery-1.4.2.min.js:1013)
7. Hover `event` in `.event.handle.apply`
8. Once the popover appears for the `event` object, move the mouse horizontally to the right onto `handle` on the same line
 => Popover is malformed (briefly flashes)

[Devin Rousso]

Created attachment 353016 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 353016 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353016&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/Popover.js:373
> +                this._animationFrameIdentifier = requestAnimationFrame(drawBackground.bind(this));

Can we add this to the constructor? I like to have all member variables defined there when possible.

    this._animationFrameIdentifier = undefined;

> Source/WebInspectorUI/UserInterface/Views/Popover.js:381
> +        cancelAnimationFrame(this._animationFrameIdentifier);

Preferably this would also clear the identifier:

    this._animationFrameIdentifier = undefined;

[Devin Rousso]

Created attachment 353051 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 353051 [details]
Patch

Clearing flags on attachment: 353051

Committed r237401: <https://trac.webkit.org/changeset/237401>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45535265>