Bug 190859 - Web Inspector: popovers for function source code are malformed
Summary: Web Inspector: popovers for function source code are malformed
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
Keywords: InRadar
Depends on:
Reported: 2018-10-23 19:22 PDT by Devin Rousso
Modified: 2018-10-24 15:14 PDT (History)
4 users (show)

See Also:

[Image] Screenshot of Issue (41.30 KB, image/png)
2018-10-23 19:22 PDT, Devin Rousso
no flags Details
Patch (7.29 KB, patch)
2018-10-23 19:29 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff
Patch (7.78 KB, patch)
2018-10-24 13:46 PDT, Devin Rousso
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2018-10-23 19:22:02 PDT
Created attachment 353015 [details]
[Image] Screenshot of Issue

1. Go to any bug on <https://bugs.webkit.org> that has a Patch attachment
2. Click "Review Patch"
3. Open WebInspector
4. Go to the Debugger tab
5. Hit the "Pause script execution" button ( || )
6. Move the mouse onto the page (WebInspector should pause on jquery-1.4.2.min.js:1013)
7. Hover `event` in `.event.handle.apply`
8. Once the popover appears for the `event` object, move the mouse horizontally to the right onto `handle` on the same line
 => Popover is malformed (briefly flashes)
Comment 1 Devin Rousso 2018-10-23 19:29:31 PDT
Created attachment 353016 [details]
Comment 2 Joseph Pecoraro 2018-10-24 12:19:38 PDT
Comment on attachment 353016 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=353016&action=review


> Source/WebInspectorUI/UserInterface/Views/Popover.js:373
> +                this._animationFrameIdentifier = requestAnimationFrame(drawBackground.bind(this));

Can we add this to the constructor? I like to have all member variables defined there when possible.

    this._animationFrameIdentifier = undefined;

> Source/WebInspectorUI/UserInterface/Views/Popover.js:381
> +        cancelAnimationFrame(this._animationFrameIdentifier);

Preferably this would also clear the identifier:

    this._animationFrameIdentifier = undefined;
Comment 3 Devin Rousso 2018-10-24 13:46:07 PDT
Created attachment 353051 [details]
Comment 4 WebKit Commit Bot 2018-10-24 15:13:01 PDT
Comment on attachment 353051 [details]

Clearing flags on attachment: 353051

Committed r237401: <https://trac.webkit.org/changeset/237401>
Comment 5 WebKit Commit Bot 2018-10-24 15:13:03 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-24 15:14:30 PDT