Bug 190846 - [PSON] When navigating back and forth, 'about:blank' shows up in the back/forward list
Summary: [PSON] When navigating back and forth, 'about:blank' shows up in the back/for...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-23 16:43 PDT by Chris Dumez
Modified: 2018-10-24 09:39 PDT (History)
7 users (show)

See Also:


Attachments
Patch (9.59 KB, patch)
2018-10-23 16:55 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (6.84 KB, patch)
2018-10-23 19:38 PDT, Chris Dumez
koivisto: review+
cdumez: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2018-10-23 16:43:57 PDT
When navigating back and forth, 'about:blank' shows up in the back/forward list.
Comment 1 Chris Dumez 2018-10-23 16:44:22 PDT
<rdar://problem/45058938>
Comment 2 Chris Dumez 2018-10-23 16:55:44 PDT
Created attachment 353006 [details]
Patch
Comment 3 Chris Dumez 2018-10-23 17:31:43 PDT
Comment on attachment 353006 [details]
Patch

Might have a better idea. Will try it out first.
Comment 4 Chris Dumez 2018-10-23 19:38:02 PDT
Created attachment 353018 [details]
Patch
Comment 5 Antti Koivisto 2018-10-24 09:30:00 PDT
Comment on attachment 353018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=353018&action=review

> Source/WebCore/loader/FrameLoader.cpp:3368
> +        if (shouldContinue == ShouldContinue::ForSuspension) {
> +            m_loadType = FrameLoadType::Standard;
>              m_provisionalDocumentLoader->willContinueMainResourceLoadAfterRedirect({ blankURL() });

Might be good to add a comment explaining why the load type is set to Standard.
Comment 6 Chris Dumez 2018-10-24 09:39:25 PDT
Committed r237386: <https://trac.webkit.org/changeset/237386>