Bug 190830 – ASSERTION FAILED: !needsLayout() in media/track/video-track-addition-and-frame-removal.html

• Status: NEW
• Component: Layout and Rendering

[Truitt Savell]

The following layout test is failing on Mojave Debug WK1

media/track/video-track-addition-and-frame-removal.html

Probable cause:

Unknown, crash has been occurring for the whole history. Test is hitting an assertion

Flakiness Dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Fvideo-track-addition-and-frame-removal.html

Log:
https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK1%20(Tests)/r237349%20(308)/media/track/video-track-addition-and-frame-removal-crash-log.txt

Excerpt:
Application Specific Information:
CRASHING TEST: media/track/video-track-addition-and-frame-removal.html

Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
0   com.apple.JavaScriptCore      	0x000000010fbc0030 WTFCrash + 16 (Assertions.cpp:255)
1   com.apple.WebCore             	0x000000011e3a6afb WTFCrashWithInfo(int, char const*, char const*, int) + 27
2   com.apple.WebCore             	0x0000000120eb501a WebCore::FrameView::paintContents(WebCore::GraphicsContext&, WebCore::IntRect const&, WebCore::Widget::SecurityOriginPaintPolicy) + 602 (FrameView.cpp:4155)
3   com.apple.WebKitLegacy        	0x0000000116431e5e -[WebFrame(WebInternal) _drawRect:contentsOnly:] + 1342 (WebFrame.mm:665)

[Alexey Proskuryakov]

ASSERTION FAILED: !needsLayout()
./page/FrameView.cpp(4155) : virtual void WebCore::FrameView::paintContents(WebCore::GraphicsContext &, const WebCore::IntRect &, WebCore::Widget::SecurityOriginPaintPolicy)

We have multiple bugs about this assertion failing, but I don't know how to tell which ones are dupes.

[Alexey Proskuryakov]

*** Bug 206714 has been marked as a duplicate of this bug. ***

[Alexey Proskuryakov]

<rdar://problem/58853165>

[Jacob Uphoff]

Created attachment 389039 [details]
Update Test Expectations

[Truitt Savell]

Comment on attachment 389039 [details]
Update Test Expectations

Clearing flags on attachment: 389039

Committed r255266: <https://trac.webkit.org/changeset/255266>

[Simon Fraser (smfr)]

This only asserts in WK1. Please adjust the expectations accordingly.

[Simon Fraser (smfr)]

Oh nm, you did.