RESOLVED FIXED 190827
TextTrack cues should be updated more often than every 250ms. 
https://bugs.webkit.org/show_bug.cgi?id=190827
Summary TextTrack cues should be updated more often than every 250ms.
Jer Noble
Reported 2018-10-23 07:47:50 PDT
TextTrack cues should be updated more often than every 250ms.
Attachments
Patch (13.38 KB, patch)
2018-10-23 07:59 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (15.01 KB, patch)
2018-10-23 08:02 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (15.20 KB, patch)
2018-10-23 08:18 PDT, Jer Noble 		jer.noble: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2018-10-23 07:48:38 PDT
<rdar://problem/45487169>
Jer Noble
Comment 2 2018-10-23 07:59:29 PDT
Created attachment 352974 [details] Patch
Jer Noble
Comment 3 2018-10-23 08:02:48 PDT
Created attachment 352975 [details] Patch
Eric Carlson
Comment 4 2018-10-23 08:12:11 PDT
Comment on attachment 352975 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352975&action=review > Source/WebCore/platform/graphics/MediaPlayer.cpp:1540 > +bool MediaPlayer::performTaskAtMediaTime(WTF::Function<void()>&& task, MediaTime time) Nit: the return bool isn't used anywhere, is it necessary?
Jer Noble
Comment 5 2018-10-23 08:16:25 PDT
(In reply to Eric Carlson from comment #4) > Comment on attachment 352975 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352975&action=review > > > Source/WebCore/platform/graphics/MediaPlayer.cpp:1540 > > +bool MediaPlayer::performTaskAtMediaTime(WTF::Function<void()>&& task, MediaTime time) > > Nit: the return bool isn't used anywhere, is it necessary? I was thinking that we could detect when the MediaPlayer didn't support performing a task at a specific time, and fall back to using a Timer. I'm not doing it in this case, because we have the existing 250ms timer to fall back upon. But other use cases of performTaskAtTime() might need to know whether the task will actually get called. TL;DR, it's not necessary now, but it may be nice to have in the future.
Jer Noble
Comment 6 2018-10-23 08:18:15 PDT
Created attachment 352977 [details] Patch for landing
Jer Noble
Comment 7 2018-10-24 02:05:21 PDT
Committed r237376: <https://trac.webkit.org/changeset/237376>
Note You need to log in before you can comment on or make changes to this bug.