Bug 190827 - TextTrack cues should be updated more often than every 250ms.
Summary: TextTrack cues should be updated more often than every 250ms.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-23 07:47 PDT by Jer Noble
Modified: 2018-10-24 02:05 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.38 KB, patch)
2018-10-23 07:59 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch (15.01 KB, patch)
2018-10-23 08:02 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (15.20 KB, patch)
2018-10-23 08:18 PDT, Jer Noble 		jer.noble: commit-queue+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2018-10-23 07:47:50 PDT 
TextTrack cues should be updated more often than every 250ms.
Comment 1 Radar WebKit Bug Importer 2018-10-23 07:48:38 PDT 
<rdar://problem/45487169>
Comment 2 Jer Noble 2018-10-23 07:59:29 PDT 
Created attachment 352974 [details]
Patch
Comment 3 Jer Noble 2018-10-23 08:02:48 PDT 
Created attachment 352975 [details]
Patch
Comment 4 Eric Carlson 2018-10-23 08:12:11 PDT 
Comment on attachment 352975 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352975&action=review

> Source/WebCore/platform/graphics/MediaPlayer.cpp:1540
> +bool MediaPlayer::performTaskAtMediaTime(WTF::Function<void()>&& task, MediaTime time)

Nit: the return bool isn't used anywhere, is it necessary?
Comment 5 Jer Noble 2018-10-23 08:16:25 PDT 
(In reply to Eric Carlson from comment #4)
> Comment on attachment 352975 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=352975&action=review
> 
> > Source/WebCore/platform/graphics/MediaPlayer.cpp:1540
> > +bool MediaPlayer::performTaskAtMediaTime(WTF::Function<void()>&& task, MediaTime time)
> 
> Nit: the return bool isn't used anywhere, is it necessary?

I was thinking that we could detect when the MediaPlayer didn't support performing a task at a specific time, and fall back to using a Timer. I'm not doing it in this case, because we have the existing 250ms timer to fall back upon. But other use cases of performTaskAtTime() might need to know whether the task will actually get called.

TL;DR, it's not necessary now, but it may be nice to have in the future.
Comment 6 Jer Noble 2018-10-23 08:18:15 PDT 
Created attachment 352977 [details]
Patch for landing
Comment 7 Jer Noble 2018-10-24 02:05:21 PDT 
Committed r237376: <https://trac.webkit.org/changeset/237376>