Bug 190817 - [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
Summary: [WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-22 19:03 PDT by Justin Fan
Modified: 2018-10-23 15:05 PDT (History)
9 users (show)

See Also:


Attachments
Patch (469.77 KB, patch)
2018-10-22 19:11 PDT, Justin Fan
no flags Details | Formatted Diff | Diff
Patch (469.31 KB, patch)
2018-10-22 19:24 PDT, Justin Fan
no flags Details | Formatted Diff | Diff
Patch (469.35 KB, patch)
2018-10-22 21:25 PDT, Justin Fan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2018-10-22 19:03:46 PDT
[WebGPU] Rename old GPU* implementation files to GPULegacy* for WebMetal
Comment 1 Justin Fan 2018-10-22 19:11:59 PDT
Created attachment 352946 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2018-10-22 19:16:15 PDT
<rdar://problem/45474393>
Comment 3 Justin Fan 2018-10-22 19:24:18 PDT
Created attachment 352947 [details]
Patch
Comment 4 EWS Watchlist 2018-10-22 19:29:05 PDT
Attachment 352947 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/metal/GPULegacyComputeCommandEncoderMetal.mm:47:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:40:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:43:  Extra space before [.  [whitespace/brackets] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:46:  Missing space after ,  [whitespace/comma] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:46:  Extra space before [.  [whitespace/brackets] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:47:  Extra space before [.  [whitespace/brackets] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:51:  Extra space before [.  [whitespace/brackets] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:54:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyDrawableMetal.mm:39:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/html/canvas/WebMetalDrawable.cpp:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyFunctionMetal.mm:39:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyDepthStencilStateMetal.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyTextureDescriptorMetal.mm:37:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyTextureDescriptorMetal.mm:38:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyRenderPipelineStateMetal.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyCommandBufferMetal.mm:42:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 16 in 121 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Justin Fan 2018-10-22 21:25:32 PDT
Created attachment 352954 [details]
Patch
Comment 6 EWS Watchlist 2018-10-22 21:30:37 PDT
Attachment 352954 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/metal/GPULegacyComputeCommandEncoderMetal.mm:47:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:40:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:43:  Extra space before [.  [whitespace/brackets] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:46:  Missing space after ,  [whitespace/comma] [3]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:46:  Extra space before [.  [whitespace/brackets] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:47:  Extra space before [.  [whitespace/brackets] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:51:  Extra space before [.  [whitespace/brackets] [5]
ERROR: Tools/TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h:54:  Multi-line string ("...") found.  This lint script doesn't do well with such strings, and may give bogus warnings.  They're ugly and unnecessary, and you should use concatenation instead".  [readability/multiline_string] [5]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyDrawableMetal.mm:39:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/html/canvas/WebMetalDrawable.cpp:43:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyFunctionMetal.mm:39:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyDepthStencilStateMetal.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyTextureDescriptorMetal.mm:37:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyTextureDescriptorMetal.mm:38:  This { should be at the end of the previous line  [whitespace/braces] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyRenderPipelineStateMetal.mm:40:  Missing spaces around :  [whitespace/init] [4]
ERROR: Source/WebCore/platform/graphics/metal/GPULegacyCommandBufferMetal.mm:42:  This { should be at the end of the previous line  [whitespace/braces] [4]
Total errors found: 16 in 121 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Dean Jackson 2018-10-23 14:13:43 PDT
Comment on attachment 352954 [details]
Patch

rs=me assuming you fix the style errors.
Comment 8 Justin Fan 2018-10-23 14:30:35 PDT
(In reply to Dean Jackson from comment #7)
> Comment on attachment 352954 [details]
> Patch
> 
> rs=me assuming you fix the style errors.

The style errors are red herrings e.g. delegated constructor calls that confuse the indentation checker and also a bunch for the multi-line string shaders.
Comment 9 WebKit Commit Bot 2018-10-23 15:05:36 PDT
Comment on attachment 352954 [details]
Patch

Clearing flags on attachment: 352954

Committed r237368: <https://trac.webkit.org/changeset/237368>
Comment 10 WebKit Commit Bot 2018-10-23 15:05:38 PDT
All reviewed patches have been landed.  Closing bug.