Turn on Conic Gradients
Created attachment 352918 [details] Patch
<rdar://problem/44576827>
Comment on attachment 352918 [details] Patch Attachment 352918 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9698649 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352928 [details] Archive of layout-test-results from ews102 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 352931 [details] Patch
Comment on attachment 352931 [details] Patch Attachment 352931 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9700254 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352942 [details] Archive of layout-test-results from ews100 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 352931 [details] Patch Attachment 352931 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9700506 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352945 [details] Archive of layout-test-results from ews107 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 352931 [details] Patch Attachment 352931 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9700525 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352949 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 352931 [details] Patch Attachment 352931 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/9700578 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html media/video-aspect-ratio.html
Created attachment 352950 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6
Comment on attachment 352931 [details] Patch Attachment 352931 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9701054 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352952 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit
Comment on attachment 352931 [details] Patch Attachment 352931 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9701604 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352955 [details] Archive of layout-test-results from ews114 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-sierra Platform: Mac OS X 10.12.6
Created attachment 352980 [details] Patch
Comment on attachment 352980 [details] Patch Attachment 352980 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9707645 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352984 [details] Archive of layout-test-results from ews103 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 352980 [details] Patch Attachment 352980 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9707655 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352985 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6
Comment on attachment 352980 [details] Patch Attachment 352980 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9707727 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352986 [details] Archive of layout-test-results from ews113 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 352980 [details] Patch Attachment 352980 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9707830 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352989 [details] Archive of layout-test-results from ews206 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews206 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Comment on attachment 352980 [details] Patch Attachment 352980 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9708672 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352994 [details] Archive of layout-test-results from ews117 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-sierra Platform: Mac OS X 10.12.6
Comment on attachment 352980 [details] Patch Attachment 352980 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9708884 New failing tests: http/wpt/css/css-images-4/conic-gradient-parsing.html
Created attachment 352995 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit
Created attachment 352997 [details] Patch
Comment on attachment 352997 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352997&action=review > Source/WebCore/Configurations/FeatureDefines.xcconfig:101 > +ENABLE_CSS_CONIC_GRADIENT_iphonesimulator = ENABLE_CSS_CONIC_GRADIENT; Where's iosmac? Also, since that means you have to revise the patch, can it be ENABLE_CSS_CONIC_GRADIENT*S* instead?
Created attachment 353053 [details] Patch
Comment on attachment 353053 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=353053&action=review > Source/WebKit/Configurations/FeatureDefines.xcconfig:103 > +ENABLE_CSS_CONIC_GRADIENTS_iosmac = ENABLE_CSS_CONIC_GRADIENTS; What about watchOS and watch simulator?
Created attachment 353056 [details] Patch for landing
Comment on attachment 353056 [details] Patch for landing Clearing flags on attachment: 353056 Committed r237402: <https://trac.webkit.org/changeset/237402>
All reviewed patches have been landed. Closing bug.