Deque's contains() and findIf() should be const as they do not modify the container.
Created attachment 352895 [details] Patch
Comment on attachment 352895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352895&action=review > Source/WTF/wtf/Deque.h:407 > + return std::find_if(begin(), end(), predicate); Considering how few clients this stuff has, maybe they could just do this themselves.
Comment on attachment 352895 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352895&action=review >> Source/WTF/wtf/Deque.h:407 >> + return std::find_if(begin(), end(), predicate); > > Considering how few clients this stuff has, maybe they could just do this themselves. I considered that but I personally do not like the std::algorithm functions as they are too verbose. I like that our container types have their own less verbose convenience methods.
Comment on attachment 352895 [details] Patch Clearing flags on attachment: 352895 Committed r237329: <https://trac.webkit.org/changeset/237329>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45465502>