Bug 190793 – Style queue exception on some security bugs

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Aakash Jain]

Noticed following logs on the webkit-misc bot:

2018-10-22 04:42:29,914 - Failed to run "['/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-misc-style', 'apply-watchlist-local', 190625]" exit_code: 1 cwd: /Volumes/Data/StyleQueue/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/show_bug.cgi?id=190625&ctype=xml&excludefield=attachmentdata
You don't have permission to view this bug.
Traceback (most recent call last):
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 305, in main
    result = command.check_arguments_and_execute(options, args, self)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 123, in check_arguments_and_execute
    return self.execute(options, args, tool) or 0
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 55, in execute
    self._sequence.run_and_handle_errors(tool, options, state)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 73, in run_and_handle_errors
    self._run(tool, options, state)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 67, in _run
    step(tool, options).run(state)
  File "/Volumes/Data/StyleQueue/WebKit/Tools/Scripts/webkitpy/tool/steps/applywatchlist.py", line 56, in run 
    cc_emails = set(cc_emails).difference(bug.cc_emails())
AttributeError: 'NoneType' object has no attribute 'cc_emails

webkit-misc:style-queue-logs buildbot$ grep "object has no attribute" *.log | wc -l
     435

[Aakash Jain]

This has been happening multiple times daily.

[~] grep "object has no attribute" *.log
style-queue_2018-11-06_04-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-11-06_04-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-11-06_04-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-11-06_04-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-11-06_10-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-11-06_10-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-11-06_10-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-11-06_10-11.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
...
...
style-queue_2018-12-05_17-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-06_01-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-06_01-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-06_09-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-06_09-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-06_09-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-06_16-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-06_16-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-07_00-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-07_00-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'
style-queue_2018-12-07_00-12.log:AttributeError: 'NoneType' object has no attribute 'cc_emails'

[Aakash Jain]

Created attachment 356788 [details]
Proposed patch

[EWS Watchlist]

Attachment 356788 [details] did not pass style-queue:


ERROR: Tools/ChangeLog:3:  Please consider whether the use of security-sensitive phrasing could help someone exploit WebKit: security bug  [changelog/unwantedsecurityterms] [3]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[EWS Watchlist]

Comment on attachment 356788 [details]
Proposed patch

Attachment 356788 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/10302526

New failing tests:
imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html

[EWS Watchlist]

Created attachment 356795 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6

[WebKit Commit Bot]

Comment on attachment 356788 [details]
Proposed patch

Clearing flags on attachment: 356788

Committed r238956: <https://trac.webkit.org/changeset/238956>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/46558454>