Bug 190781 - Use Location = "Relative to Build Products" rather than "Relative to Group"
Summary: Use Location = "Relative to Build Products" rather than "Relative to Group"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-21 14:47 PDT by Keith Rollin
Modified: 2018-10-22 16:59 PDT (History)
10 users (show)

See Also:


Attachments
Patch (696.59 KB, patch)
2018-10-21 14:56 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2018-10-21 14:47:30 PDT
Almost all Derived Files are included in Xcode projects with the Location attribute set to "Relative to Group". While this currently works, the Derived Files can no longer be found when enabling XCBuild (which has stricter requirements). Fix this by setting the Location attribute to "Relative to Build Products".
Comment 1 Keith Rollin 2018-10-21 14:56:37 PDT
Created attachment 352876 [details]
Patch
Comment 2 Alexey Proskuryakov 2018-10-22 15:32:56 PDT
Comment on attachment 352876 [details]
Patch

It may be useful to add a style checker rule for this, so that people don't keep adding files with the old style.
Comment 3 Radar WebKit Bug Importer 2018-10-22 15:33:33 PDT
<rdar://problem/45468803>
Comment 4 Radar WebKit Bug Importer 2018-10-22 15:33:36 PDT
<rdar://problem/45468808>
Comment 5 WebKit Commit Bot 2018-10-22 16:59:00 PDT
Comment on attachment 352876 [details]
Patch

Clearing flags on attachment: 352876

Committed r237340: <https://trac.webkit.org/changeset/237340>
Comment 6 WebKit Commit Bot 2018-10-22 16:59:02 PDT
All reviewed patches have been landed.  Closing bug.