fast/forms/datalist/datalist-show-hide.html fails with a text diff: @@ -1,8 +1,9 @@ CLICK -PASS showingList is "true" +FAIL showingList should be true. Was false. BLUR PASS showingList is "false" PASS successfullyParsed is true +Some tests failed.
I think this was intended to test that the datalist suggestions menu can be presented and hidden. This test works on macOS by clicking to focus and then blurring the field; we could also make it test iOS by implementing UIScriptController::isShowingDataListSuggestions and also tweaking the test to switch between datalist suggestions and the regular keyboard by tapping on different parts of the datalist input.
Created attachment 352864 [details] Patch
Created attachment 352867 [details] Fix DRT build
<rdar://problem/45456361>
Comment on attachment 352867 [details] Fix DRT build View in context: https://bugs.webkit.org/attachment.cgi?id=352867&action=review > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:806 > + if ([NSStringFromClass(window.class) isEqualToString:@"UIRemoteKeyboardWindow"]) Feels weird that this is a string compare instead of a class compare (store NSClassFromString("UIRemoteKeyboardWindow") at the top of the function and compare against that). But it also does not matter at all.
Comment on attachment 352867 [details] Fix DRT build View in context: https://bugs.webkit.org/attachment.cgi?id=352867&action=review >> Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:806 >> + if ([NSStringFromClass(window.class) isEqualToString:@"UIRemoteKeyboardWindow"]) > > Feels weird that this is a string compare instead of a class compare (store NSClassFromString("UIRemoteKeyboardWindow") at the top of the function and compare against that). But it also does not matter at all. Good call — changed to check -isKindOfClass: instead.
Created attachment 352900 [details] Patch for landing
Comment on attachment 352900 [details] Patch for landing Clearing flags on attachment: 352900 Committed r237328: <https://trac.webkit.org/changeset/237328>