Bug 190769 – [Regression r237141] profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js is broken

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: JavaScriptCore

[Mark Lam]

Run this:
$ ./Tools/Scripts/run-javascriptcore-tests --debug --no-build --no-testmasm --no-testapi --no-testair --no-testb3 --filter profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js

... and get this:

profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: ASSERTION FAILED: m_next == strlen(m_buffer)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: /Volumes/Data/ws6/OpenSource/Source/WTF/wtf/StringPrintStream.cpp(88) : WTF::CString WTF::StringPrintStream::toCString()
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 1   0x1064677f9 WTFCrash
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 2   0x10646864b WTFCrashWithInfo(int, char const*, char const*, int)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 3   0x1065050a7 WTF::StringPrintStream::toCString()
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 4   0x107709087 JSC::Profiler::BytecodeSequence::BytecodeSequence(JSC::CodeBlock*)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 5   0x1077099e3 JSC::Profiler::Bytecodes::Bytecodes(unsigned long, JSC::CodeBlock*)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 6   0x107709a65 JSC::Profiler::Bytecodes::Bytecodes(unsigned long, JSC::CodeBlock*)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 7   0x10770cf75 JSC::Profiler::Database::ensureBytecodesFor(WTF::AbstractLocker const&, JSC::CodeBlock*)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 8   0x10770e8f0 JSC::Profiler::Database::logEvent(JSC::CodeBlock*, char const*, WTF::CString const&)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 9   0x1079d50c2 void JSC::VM::logEvent<JSC::ScriptExecutable::installCode(JSC::VM&, JSC::CodeBlock*, JSC::CodeType, JSC::CodeSpecializationKind)::$_12>(JSC::CodeBlock*, char const*, JSC::ScriptExecutable::installCode(JSC::VM&, JSC::CodeBlock*, JSC::CodeType, JSC::CodeSpecializationKind)::$_12 const&)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 10  0x1079d4784 JSC::ScriptExecutable::installCode(JSC::VM&, JSC::CodeBlock*, JSC::CodeType, JSC::CodeSpecializationKind)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 11  0x1079d6fcc JSC::ScriptExecutable::prepareForExecutionImpl(JSC::VM&, JSC::JSFunction*, JSC::JSScope*, JSC::CodeSpecializationKind, JSC::CodeBlock*&)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 12  0x1074c1a90 JSC::JSObject* JSC::ScriptExecutable::prepareForExecution<JSC::FunctionExecutable>(JSC::VM&, JSC::JSFunction*, JSC::JSScope*, JSC::CodeSpecializationKind, JSC::CodeBlock*&)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 13  0x1075bf164 JSC::LLInt::setUpCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind, JSC::JSValue, JSC::LLIntCallLinkInfo*)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 14  0x1075bdd96 JSC::LLInt::genericCall(JSC::ExecState*, JSC::Instruction*, JSC::CodeSpecializationKind)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 15  0x1075bdc41 llint_slow_path_call
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 16  0x1069125f6 llint_entry
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 17  0x106912608 llint_entry
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 18  0x106912608 llint_entry
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 19  0x106909f22 vmEntryToJavaScript
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 20  0x1074c123e JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 21  0x1074c07af JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 22  0x10779a785 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 23  0x102981d6b runWithOptions(GlobalObject*, CommandLine&, bool&)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 24  0x1029593ec jscmain(int, char**)::$_3::operator()(JSC::VM&, GlobalObject*, bool&) const
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 25  0x10293e144 int runJSC<jscmain(int, char**)::$_3>(CommandLine, bool, jscmain(int, char**)::$_3 const&)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 26  0x10293cbff jscmain(int, char**)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 27  0x10293cb5e main
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 28  0x7fff5f2d2015 start
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: ../../../../.helpers/profiler-test-helper:31:in `mysys': Command ["../../../../.vm/JavaScriptCore.framework/Resources/jsc", "--useConcurrentJIT=false", "-p", "/Volumes/Data/ws6/OpenSource/WebKitBuild/Debug/jsc-stress-results/_payload/temp-3.json", "date-format-xparb.js"] failed: #<Process::Status: pid 66130 SIGSEGV (signal 11)> (RuntimeError)
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: 	from ../../../../.helpers/profiler-test-helper:34:in `<main>'
profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler: ERROR: Unexpected exit code: 1
1/1 (failed 1) 

** The following JSC stress test failures have been introduced:
	profiler-test.yaml/tests/sunspider-1.0/date-format-xparb.js.profiler

Results for JSC stress tests:
    1 failure found.

But if we roll out r237141, it passes again.

[Mark Lam]

Keith, I'm assigning this to you since your change in r237141: <https://trac.webkit.org/changeset/237141> caused the regression.

[Radar WebKit Bug Importer]

<rdar://problem/45422770>

[Mark Lam]

FYI, you'll need a debug build to reproduce the issue.  I don't think it manifests on a release build.

[Mark Lam]

Looks like Ryan already filed a bug for this, but we didn't get cc'ed on it until now.  I'm duping this to his.

*** This bug has been marked as a duplicate of bug 190695 ***