Bug 190739 - Add test expectations for webgpu-enabled.html
Summary: Add test expectations for webgpu-enabled.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Justin Fan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-18 15:50 PDT by Justin Fan
Modified: 2018-10-18 20:55 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.09 KB, patch)
2018-10-18 15:53 PDT, Justin Fan
no flags Details | Formatted Diff | Diff
Patch (4.45 KB, patch)
2018-10-18 16:28 PDT, Justin Fan
no flags Details | Formatted Diff | Diff
Patch (5.12 KB, patch)
2018-10-18 19:04 PDT, Justin Fan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Justin Fan 2018-10-18 15:50:43 PDT
Add test expectations for webgpu-enabled.html
Comment 1 Justin Fan 2018-10-18 15:53:25 PDT
Created attachment 352742 [details]
Patch
Comment 2 Ryan Haddad 2018-10-18 16:04:35 PDT
Should the test be skipped on WK1? It looks like the results there are different:

CONSOLE MESSAGE: line 11: TypeError: undefined is not an object (evaluating 'window.webgpu.requestAdapter')
FAIL undefined should be defined. Was undefined
FAIL successfullyParsed should be true (of type boolean). Was undefined (of type undefined).

TEST COMPLETE

https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/r237266%20(401)/results.html
Comment 3 Justin Fan 2018-10-18 16:28:17 PDT
Created attachment 352745 [details]
Patch
Comment 4 Justin Fan 2018-10-18 16:28:58 PDT
(In reply to Ryan Haddad from comment #2)
> Should the test be skipped on WK1? It looks like the results there are
> different:
> 
> CONSOLE MESSAGE: line 11: TypeError: undefined is not an object (evaluating
> 'window.webgpu.requestAdapter')
> FAIL undefined should be defined. Was undefined
> FAIL successfullyParsed should be true (of type boolean). Was undefined (of
> type undefined).
> 
> TEST COMPLETE
> 
> https://build.webkit.org/results/Apple%20Mojave%20Release%20WK1%20(Tests)/
> r237266%20(401)/results.html

Thanks for the catch. Updated some test expectations to match.
Comment 5 Justin Fan 2018-10-18 19:04:48 PDT
Created attachment 352754 [details]
Patch
Comment 6 WebKit Commit Bot 2018-10-18 20:54:58 PDT
Comment on attachment 352754 [details]
Patch

Clearing flags on attachment: 352754

Committed r237279: <https://trac.webkit.org/changeset/237279>
Comment 7 WebKit Commit Bot 2018-10-18 20:54:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2018-10-18 20:55:29 PDT
<rdar://problem/45394807>