RESOLVED FIXED 190737
Remove PLATFORM(IOS) for now 
https://bugs.webkit.org/show_bug.cgi?id=190737
Summary Remove PLATFORM(IOS) for now
Alexey Proskuryakov
Reported 2018-10-18 14:47:42 PDT
Need to wait until most in-flight patches that expect PLATFORM(IOS) to be true on all iOS family OSes are no longer relevant. It's better to have them break the build than for the conflict to go unnoticed. In a few weeks, will reintroduce PLATFORM(IOS) with the new meaning.
Attachments
proposed patch (1.65 KB, patch)
2018-10-18 14:53 PDT, Alexey Proskuryakov 		thorton: review+
DetailsFormatted DiffDiff
proposed patch (1.66 KB, patch)
2018-10-18 14:58 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (1.73 KB, patch)
2018-10-18 17:00 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2018-10-18 14:53:13 PDT
Created attachment 352737 [details] proposed patch
EWS Watchlist
Comment 2 2018-10-18 14:56:27 PDT
Attachment 352737 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Platform.h:376: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:377: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:527: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:528: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:531: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] ERROR: Source/WTF/wtf/Platform.h:532: CPP comments are not allowed in Platform.h, please use C comments /* ... */ [build/cpp_comment] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2018-10-18 14:58:40 PDT
Created attachment 352738 [details] proposed patch Oops, thank you style queue.
Alexey Proskuryakov
Comment 4 2018-10-18 17:00:33 PDT
Created attachment 352748 [details] proposed patch With fewer mistakes...
Alexey Proskuryakov
Comment 5 2018-10-18 17:55:21 PDT
Committed http://trac.webkit.org/r237277
Radar WebKit Bug Importer
Comment 6 2018-10-18 17:56:21 PDT
<rdar://problem/45391620>
Note You need to log in before you can comment on or make changes to this bug.