Bug 190737 - Remove PLATFORM(IOS) for now
Summary: Remove PLATFORM(IOS) for now
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-18 14:47 PDT by Alexey Proskuryakov
Modified: 2018-10-18 17:56 PDT (History)
7 users (show)

See Also:

Attachments
proposed patch (1.65 KB, patch)
2018-10-18 14:53 PDT, Alexey Proskuryakov 		thorton: review+
Details | Formatted Diff | Diff
proposed patch (1.66 KB, patch)
2018-10-18 14:58 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
proposed patch (1.73 KB, patch)
2018-10-18 17:00 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2018-10-18 14:47:42 PDT 
Need to wait until most in-flight patches that expect PLATFORM(IOS) to be true on all iOS family OSes are no longer relevant. It's better to have them break the build than for the conflict to go unnoticed.

In a few weeks, will reintroduce PLATFORM(IOS) with the new meaning.
Comment 1 Alexey Proskuryakov 2018-10-18 14:53:13 PDT 
Created attachment 352737 [details]
proposed patch
Comment 2 EWS Watchlist 2018-10-18 14:56:27 PDT 
Attachment 352737 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Platform.h:376:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
ERROR: Source/WTF/wtf/Platform.h:377:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
ERROR: Source/WTF/wtf/Platform.h:527:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
ERROR: Source/WTF/wtf/Platform.h:528:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
ERROR: Source/WTF/wtf/Platform.h:531:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
ERROR: Source/WTF/wtf/Platform.h:532:  CPP comments are not allowed in Platform.h, please use C comments /* ... */  [build/cpp_comment] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2018-10-18 14:58:40 PDT 
Created attachment 352738 [details]
proposed patch

Oops, thank you style queue.
Comment 4 Alexey Proskuryakov 2018-10-18 17:00:33 PDT 
Created attachment 352748 [details]
proposed patch

With fewer mistakes...
Comment 5 Alexey Proskuryakov 2018-10-18 17:55:21 PDT 
Committed http://trac.webkit.org/r237277
Comment 6 Radar WebKit Bug Importer 2018-10-18 17:56:21 PDT 
<rdar://problem/45391620>