Bug 190736 - Attachment filenames with RTL characters should format similar to Finder
Summary: Attachment filenames with RTL characters should format similar to Finder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-18 14:28 PDT by Tim Horton
Modified: 2018-10-24 15:51 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.51 KB, patch)
2018-10-18 14:28 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2018-10-18 14:28:39 PDT 
Attachment filenames with RTL characters should format similar to Finder
Comment 1 Tim Horton 2018-10-18 14:28:57 PDT 
Created attachment 352733 [details]
Patch
Comment 2 Tim Horton 2018-10-18 14:28:59 PDT 
<rdar://problem/44735946>
Comment 3 mitz 2018-10-24 14:09:22 PDT 
Comment on attachment 352733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352733&action=review

> Source/WebCore/html/HTMLAttachmentElement.cpp:163
> +String HTMLAttachmentElement::attachmentTitleForDisplay() const

Not redundant at all.
Comment 4 Tim Horton 2018-10-24 15:26:00 PDT 
Comment on attachment 352733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352733&action=review

>> Source/WebCore/html/HTMLAttachmentElement.cpp:163
>> +String HTMLAttachmentElement::attachmentTitleForDisplay() const
> 
> Not redundant at all.

🤷‍♂️ I was afraid of just calling the other one title(), and this one just continues the madness.
Comment 5 WebKit Commit Bot 2018-10-24 15:51:09 PDT 
Comment on attachment 352733 [details]
Patch

Clearing flags on attachment: 352733

Committed r237403: <https://trac.webkit.org/changeset/237403>
Comment 6 WebKit Commit Bot 2018-10-24 15:51:11 PDT 
All reviewed patches have been landed.  Closing bug.