RESOLVED FIXED190736
Attachment filenames with RTL characters should format similar to Finder 
https://bugs.webkit.org/show_bug.cgi?id=190736
Summary Attachment filenames with RTL characters should format similar to Finder
Tim Horton
Reported 2018-10-18 14:28:39 PDT
Attachment filenames with RTL characters should format similar to Finder
Attachments
Patch (10.51 KB, patch)
2018-10-18 14:28 PDT, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2018-10-18 14:28:57 PDT
Created attachment 352733 [details] Patch
Tim Horton
Comment 2 2018-10-18 14:28:59 PDT
<rdar://problem/44735946>
mitz
Comment 3 2018-10-24 14:09:22 PDT
Comment on attachment 352733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352733&action=review > Source/WebCore/html/HTMLAttachmentElement.cpp:163 > +String HTMLAttachmentElement::attachmentTitleForDisplay() const Not redundant at all.
Tim Horton
Comment 4 2018-10-24 15:26:00 PDT
Comment on attachment 352733 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352733&action=review >> Source/WebCore/html/HTMLAttachmentElement.cpp:163 >> +String HTMLAttachmentElement::attachmentTitleForDisplay() const > > Not redundant at all. 🤷‍♂️ I was afraid of just calling the other one title(), and this one just continues the madness.
WebKit Commit Bot
Comment 5 2018-10-24 15:51:09 PDT
Comment on attachment 352733 [details] Patch Clearing flags on attachment: 352733 Committed r237403: <https://trac.webkit.org/changeset/237403>
WebKit Commit Bot
Comment 6 2018-10-24 15:51:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.