Bug 190731 - Clean up FrameLoader two-state enums
Summary: Clean up FrameLoader two-state enums
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-18 13:41 PDT by Alex Christensen
Modified: 2018-10-18 14:18 PDT (History)
7 users (show)

See Also:

Attachments
Patch (30.08 KB, patch)
2018-10-18 13:51 PDT, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-10-18 13:41:20 PDT 
Clean up FrameLoader two-state enums
Comment 1 Alex Christensen 2018-10-18 13:51:20 PDT 
Created attachment 352726 [details]
Patch
Comment 2 EWS Watchlist 2018-10-18 13:54:32 PDT 
Attachment 352726 [details] did not pass style-queue:


ERROR: Source/WebCore/loader/EmptyFrameLoaderClient.h:78:  Inline functions should not be in classes annotated with WEBCORE_EXPORT. Remove the macro from the class and apply it to each appropriate method, or move the inline function definition out-of-line.  [build/webcore_export] [4]
Total errors found: 1 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alex Christensen 2018-10-18 14:17:07 PDT 
http://trac.webkit.org/r237264
Comment 4 Radar WebKit Bug Importer 2018-10-18 14:18:41 PDT 
<rdar://problem/45384056>