Bug 190730 - [WebVTT] The TextTrackLoader parameter in TextTrackLoaderClient virtual methods should be a reference
Summary: [WebVTT] The TextTrackLoader parameter in TextTrackLoaderClient virtual metho...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-18 13:37 PDT by Per Arne Vollan
Modified: 2018-10-18 14:30 PDT (History)
12 users (show)

See Also:

Attachments
Patch (5.27 KB, patch)
2018-10-18 13:39 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2018-10-18 13:37:19 PDT 
It is currently a pointer.
Comment 1 Radar WebKit Bug Importer 2018-10-18 13:38:06 PDT 
<rdar://problem/45382278>
Comment 2 Per Arne Vollan 2018-10-18 13:39:37 PDT 
Created attachment 352725 [details]
Patch
Comment 3 Chris Dumez 2018-10-18 13:44:32 PDT 
Comment on attachment 352725 [details]
Patch

r=me if the bots are happy.
Comment 4 Per Arne Vollan 2018-10-18 13:54:18 PDT 
Comment on attachment 352725 [details]
Patch

Thanks for reviewing!
Comment 5 WebKit Commit Bot 2018-10-18 14:30:36 PDT 
Comment on attachment 352725 [details]
Patch

Clearing flags on attachment: 352725

Committed r237265: <https://trac.webkit.org/changeset/237265>
Comment 6 WebKit Commit Bot 2018-10-18 14:30:38 PDT 
All reviewed patches have been landed.  Closing bug.