SuspendedPages do not report meaningful domains in Activity Monitor, which makes debugging harder.
<rdar://problem/45059699>
Created attachment 352701 [details] Patch
Comment on attachment 352701 [details] Patch r=me. Can't this be tested?
(In reply to Alex Christensen from comment #3) > Comment on attachment 352701 [details] > Patch > > r=me. Can't this be tested? It will need some infrastructure to ask a WebProcess what origins it reports but I think it is doable. Will look into it now.
Created attachment 352723 [details] Patch
Requesting review again now that I added API testing.
Comment on attachment 352723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352723&action=review > Source/WebKit/UIProcess/WebProcessProxy.cpp:1410 > + sendSync(Messages::WebProcess::GetActivePagesOriginsForTesting(), Messages::WebProcess::GetActivePagesOriginsForTesting::Reply(activeDomains), 0); tsk tsk tsk, this is what completion handlers are for. > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:530 > + [handler addMappingFromURLString:@"pson://www.google.com/main.html" toData:testBytes]; Is this a URL we can use for testing?
Comment on attachment 352723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352723&action=review >> Source/WebKit/UIProcess/WebProcessProxy.cpp:1410 >> + sendSync(Messages::WebProcess::GetActivePagesOriginsForTesting(), Messages::WebProcess::GetActivePagesOriginsForTesting::Reply(activeDomains), 0); > > tsk tsk tsk, this is what completion handlers are for. This is only used for testing. If I make this async, then I need to IPC messages right? (one in each direction). >> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:530 >> + [handler addMappingFromURLString:@"pson://www.google.com/main.html" toData:testBytes]; > > Is this a URL we can use for testing? This is using PSON protocol. We use proper domains names in PSON tests so that process-swap on cross-site navigation actually triggers.
Comment on attachment 352723 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352723&action=review >>> Source/WebKit/UIProcess/WebProcessProxy.cpp:1410 >>> + sendSync(Messages::WebProcess::GetActivePagesOriginsForTesting(), Messages::WebProcess::GetActivePagesOriginsForTesting::Reply(activeDomains), 0); >> >> tsk tsk tsk, this is what completion handlers are for. > > This is only used for testing. If I make this async, then I need to IPC messages right? (one in each direction). s/to/two/
Comment on attachment 352723 [details] Patch Clearing flags on attachment: 352723 Committed r237267: <https://trac.webkit.org/changeset/237267>
All reviewed patches have been landed. Closing bug.