RESOLVED FIXED 190720
[LFC][IFC] RenderReplaced renderer should create InlineBox 
https://bugs.webkit.org/show_bug.cgi?id=190720
Summary [LFC][IFC] RenderReplaced renderer should create InlineBox
zalan
Reported 2018-10-18 09:39:56 PDT
ssia
Attachments
Patch (2.80 KB, patch)
2018-10-18 09:41 PDT, zalan 		koivisto: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2018-10-18 09:41:44 PDT
Created attachment 352700 [details] Patch
Antti Koivisto
Comment 2 2018-10-19 08:47:36 PDT
Comment on attachment 352700 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352700&action=review > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:91 > + box = new InlineBox( { }, RenderStyle::createAnonymousStyleWithDisplay(rootRenderer.style(), DisplayType::Inline)); Using new is lame. Can we use unique_ptrs and make_unique for safe memory management here?
zalan
Comment 3 2018-10-19 10:00:30 PDT
(In reply to Antti Koivisto from comment #2) > Comment on attachment 352700 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=352700&action=review > > > Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:91 > > + box = new InlineBox( { }, RenderStyle::createAnonymousStyleWithDisplay(rootRenderer.style(), DisplayType::Inline)); > > Using new is lame. Can we use unique_ptrs and make_unique for safe memory > management here? Absolutely!
zalan
Comment 4 2018-10-19 10:28:19 PDT
Committed r237293: <https://trac.webkit.org/changeset/237293>
Radar WebKit Bug Importer
Comment 5 2018-10-19 10:29:26 PDT
<rdar://problem/45409011>
Note You need to log in before you can comment on or make changes to this bug.