Bug 190711 - [GTK] fast/selectors/read-only-read-write-input-basics.html failing since r237245 - Enable the datalist element by default on iOS and macOS
Summary: [GTK] fast/selectors/read-only-read-write-input-basics.html failing since r23...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-18 08:05 PDT by Miguel Gomez
Modified: 2018-10-27 18:54 PDT (History)
4 users (show)

See Also:


Attachments
Patch for EWS (149.42 KB, patch)
2018-10-18 08:27 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch for EWS (567.12 KB, patch)
2018-10-18 08:40 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Miguel Gomez 2018-10-18 08:05:32 PDT
fast/selectors/read-only-read-write-input-basics.html [ Failure ]

The diff is quite bit, can be seen here

https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r237249%20(8526)/fast/selectors/read-only-read-write-input-basics-pretty-diff.html

The test was update in the bug, and the Apple ports have custom expectations for their ports. Not sure we should add our own or if this is really a bug.
Comment 1 Wenson Hsieh 2018-10-18 08:16:18 PDT
I think we should restore the baseline (fast/selectors/read-only-read-write-input-basics-expected.txt) to what it was prior to r237245.
Comment 2 Wenson Hsieh 2018-10-18 08:27:48 PDT
Created attachment 352691 [details]
Patch for EWS
Comment 3 Wenson Hsieh 2018-10-18 08:40:31 PDT
Created attachment 352693 [details]
Patch for EWS
Comment 4 WebKit Commit Bot 2018-10-18 10:12:07 PDT
Comment on attachment 352693 [details]
Patch for EWS

Clearing flags on attachment: 352693

Committed r237258: <https://trac.webkit.org/changeset/237258>
Comment 5 WebKit Commit Bot 2018-10-18 10:12:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Wenson Hsieh 2018-10-18 10:13:13 PDT
(In reply to Miguel Gomez from comment #0)
> fast/selectors/read-only-read-write-input-basics.html [ Failure ]
> 
> The diff is quite bit, can be seen here
> 
> https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/
> r237249%20(8526)/fast/selectors/read-only-read-write-input-basics-pretty-
> diff.html
> 
> The test was update in the bug, and the Apple ports have custom expectations
> for their ports. Not sure we should add our own or if this is really a bug.

Please let me know whether the rebaselining fixes the test failures you're seeing!
Comment 7 Michael Catanzaro 2018-10-27 18:54:00 PDT
Confirming fast/selectors/read-only-read-write-input-basics.html is fixed. Removing the failure expectation. Thanks Wenson!