Bug 190694 - AI does not clear Phantom allocation nodes.
Summary: AI does not clear Phantom allocation nodes.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-17 17:38 PDT by Keith Miller
Modified: 2018-10-17 21:28 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.24 KB, patch)
2018-10-17 17:40 PDT, Keith Miller 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2018-10-17 17:38:09 PDT 
AI does not clear Phantom allocation nodes.
Comment 1 Keith Miller 2018-10-17 17:40:01 PDT 
Created attachment 352667 [details]
Patch
Comment 2 Saam Barati 2018-10-17 17:41:51 PDT 
Comment on attachment 352667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352667&action=review

r=me

> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2578
>          // This claims to return bottom.

nit: IMO We don't really need this comment anymore since it just says exactly what the code is doing.
Comment 3 Keith Miller 2018-10-17 17:44:30 PDT 
Comment on attachment 352667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352667&action=review

>> Source/JavaScriptCore/dfg/DFGAbstractInterpreterInlines.h:2578
>>          // This claims to return bottom.
> 
> nit: IMO We don't really need this comment anymore since it just says exactly what the code is doing.

Fair enough, I'll remove.
Comment 4 Keith Miller 2018-10-17 20:18:15 PDT 
Committed r237244: <https://trac.webkit.org/changeset/237244>
Comment 5 Keith Miller 2018-10-17 20:18:51 PDT 
rdar://problem/45218452
Comment 6 Radar WebKit Bug Importer 2018-10-17 20:19:22 PDT 
<rdar://problem/45360871>
Comment 7 Mark Lam 2018-10-17 21:28:40 PDT 
<rdar://problem/45218452>