Bug 190681 - Handle MDNS resolution of candidates through libwebrtc directly
Summary: Handle MDNS resolution of candidates through libwebrtc directly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-17 12:48 PDT by youenn fablet
Modified: 2018-10-29 14:31 PDT (History)
5 users (show)

See Also:

Attachments
Patch (31.73 KB, patch)
2018-10-17 13:49 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (34.42 KB, patch)
2018-10-29 07:37 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2018-10-17 12:48:39 PDT 
Libwebrtc has proper support for MDNS name resolution.
Let's use that.
Comment 1 youenn fablet 2018-10-17 13:49:17 PDT 
Created attachment 352633 [details]
Patch
Comment 2 WebKit Commit Bot 2018-10-18 11:15:26 PDT 
Comment on attachment 352633 [details]
Patch

Clearing flags on attachment: 352633

Committed r237261: <https://trac.webkit.org/changeset/237261>
Comment 3 WebKit Commit Bot 2018-10-18 11:15:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2018-10-18 11:16:24 PDT 
<rdar://problem/45377118>
Comment 5 Ryan Haddad 2018-10-23 14:07:20 PDT 
Reverted r237261 for reason:

The layout test for this change crashes under GuardMalloc.

Committed r237367: <https://trac.webkit.org/changeset/237367>
Comment 6 Ryan Haddad 2018-10-23 14:07:53 PDT 
(In reply to Ryan Haddad from comment #5)
> Reverted r237261 for reason:
> 
> The layout test for this change crashes under GuardMalloc.
> 
> Committed r237367: <https://trac.webkit.org/changeset/237367>
Details in radar.
Comment 7 youenn fablet 2018-10-29 07:37:01 PDT 
Created attachment 353288 [details]
Patch
Comment 8 Eric Carlson 2018-10-29 11:31:04 PDT 
Comment on attachment 353288 [details]
Patch

still looks good to me
Comment 9 WebKit Commit Bot 2018-10-29 14:31:24 PDT 
Comment on attachment 353288 [details]
Patch

Clearing flags on attachment: 353288

Committed r237568: <https://trac.webkit.org/changeset/237568>
Comment 10 WebKit Commit Bot 2018-10-29 14:31:25 PDT 
All reviewed patches have been landed.  Closing bug.