Bug 190659 - [JSC] More aggressively use `constexpr` in LowLevelInterpreter.asm for constant values
Summary: [JSC] More aggressively use `constexpr` in LowLevelInterpreter.asm for consta...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-17 00:57 PDT by Yusuke Suzuki
Modified: 2018-10-17 08:50 PDT (History)
6 users (show)

See Also:


Attachments
Patch (35.29 KB, patch)
2018-10-17 01:08 PDT, Yusuke Suzuki
keith_miller: review+
Details | Formatted Diff | Diff
Patch (35.33 KB, patch)
2018-10-17 08:00 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2018-10-17 00:57:50 PDT
[JSC] More aggressively use `constexpr` in LowLevelInterpreter.asm for constant values
Comment 1 Yusuke Suzuki 2018-10-17 01:08:12 PDT
Created attachment 352556 [details]
Patch
Comment 2 EWS Watchlist 2018-10-17 01:11:37 PDT
Attachment 352556 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:101:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:105:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keith Miller 2018-10-17 07:23:13 PDT
Comment on attachment 352556 [details]
Patch

r=me. I could have sworn I did some of these already... Oh well. Nice patch!
Comment 4 Yusuke Suzuki 2018-10-17 08:00:00 PDT
Created attachment 352566 [details]
Patch
Comment 5 EWS Watchlist 2018-10-17 08:02:20 PDT
Attachment 352566 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:101:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/JavaScriptCore/llint/LLIntData.cpp:105:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Yusuke Suzuki 2018-10-17 08:49:02 PDT
Committed r237220: <https://trac.webkit.org/changeset/237220>
Comment 7 Radar WebKit Bug Importer 2018-10-17 08:50:43 PDT
<rdar://problem/45339486>