Implement support for parsing paint() images in css, and store CSS paint callback objects in the paint definition map.
Created attachment 352551 [details] Patch
Created attachment 352590 [details] Patch
Created attachment 352652 [details] Patch
Comment on attachment 352652 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352652&action=review > Source/WebCore/css/CSSImageGeneratorValue.cpp:155 > + return nullptr; Not essential, but it seems you'll need to implement image() isFixedSize() fixedSize() isPending() and knownToBeOpaque() anyway, so maybe you should do that now with stubs? > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1294 > + // FIXME: should parse arguments Nit: . > Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp:1296 > + while (!args.atEnd()) > + args.consume(); Should you return nullptr if there are arguments for now? I guess not. > Source/WebCore/platform/mediastream/mac/RealtimeVideoUtilities.h:27 > +#pragma once > + Wow :)
Created attachment 352656 [details] Patch
Comment on attachment 352656 [details] Patch Clearing flags on attachment: 352656 Committed r237243: <https://trac.webkit.org/changeset/237243>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45360435>
Comment on attachment 352656 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352656&action=review > Source/WebCore/css/CSSPaintImageValue.cpp:40 > + result.append(m_name); Drive-by, but I think this needs to be escaped as an identifier. I'm ~sure this would yield wrong results for stuff like paint(foo\ bar).