WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
190654
Update more DOMWindow getters to return references instead of raw pointers
https://bugs.webkit.org/show_bug.cgi?id=190654
Summary
Update more DOMWindow getters to return references instead of raw pointers
Chris Dumez
Reported
2018-10-16 16:57:03 PDT
Update more DOMWindow getters to return references instead of raw pointers.
Attachments
Patch
(21.53 KB, patch)
2018-10-16 19:33 PDT
,
Chris Dumez
youennf
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2018-10-16 19:33:11 PDT
Created
attachment 352539
[details]
Patch
youenn fablet
Comment 2
2018-10-17 11:06:12 PDT
Comment on
attachment 352539
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=352539&action=review
> Source/WebCore/dom/Document.cpp:2836 > + return &window->location();
one liner?
Chris Dumez
Comment 3
2018-10-17 11:11:24 PDT
Committed
r237228
: <
https://trac.webkit.org/changeset/237228
>
Radar WebKit Bug Importer
Comment 4
2018-10-17 11:12:31 PDT
<
rdar://problem/45344354
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug