Bug 190651 – Regression(r236795) Check boxes are sometimes checked when they should not be

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Check boxes are sometimes checked when they should not be after r236795 because the input's dirty checkedness flag is set to false when it should not:
- https://html.spec.whatwg.org/#concept-input-checked-dirty-flag

[Chris Dumez]

<rdar://problem/45319934>

[Chris Dumez]

Created attachment 352515 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 352515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352515&action=review

> LayoutTests/ChangeLog:12
> +        * fast/dom/HTMLInputElement/checkbox-dirty-checkedness-flag-expected.txt: Added.
> +        * fast/dom/HTMLInputElement/checkbox-dirty-checkedness-flag.html: Added.

Maybe we should add another test which sets the dirty checked flag true and mutates attributes if there is not a test like that already.

> LayoutTests/fast/dom/HTMLInputElement/checkbox-dirty-checkedness-flag.html:7
> +description("Tests that setting the 'checked' attribute does not set its dirty checkedness flag.");

say 'checked' content attribute to distinguish it from IDL attribute?

[Chris Dumez]

Created attachment 352518 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 352518 [details]
Patch

Clearing flags on attachment: 352518

Committed r237211: <https://trac.webkit.org/changeset/237211>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.