Bug 190640 – Remove InjectedBundleBackForwardList

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Alex Christensen]

Remove InjectedBundleBackForwardList

[Alex Christensen]

Created attachment 352506 [details]
Patch

[Chris Dumez]

Comment on attachment 352506 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352506&action=review

r=me with suggestion, assuming the bots are happy.

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1673
> +void WebPage::clearHistory()

This merely sends an async IPC to the UIProcess, asking it to clear its back forward list. The UIProcess will then send async IPC to the WebProcess for each history item removal.

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:415
> +    WKBundleClearHistoryForTesting(m_page);

This merely asks the UIProcess to clear the history. Can we clear the history directly from the UIProcess in TestController::resetStateToConsistentValues() using WKBackForwardListClear()? It would end up through the same code path but would do less IPC.

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:613
>  void TestRunner::clearBackForwardList()

Note that we may be able to drop this in a follow-up, now that you clear history between tests. I think all the tests merely call this before starting, although we should double check.
It'd be great if we could get rid of it because this would mean we could drop WKBundleClearHistoryForTesting() too.

[Alex Christensen]

I agree that there are several messages being sent that shouldn't be, but that will be cleaned up soon.
http://trac.webkit.org/r237205

[Radar WebKit Bug Importer]

<rdar://problem/45320784>