Bug 190623 - [GLib] Build error with RemoteInspector disabled
Summary: [GLib] Build error with RemoteInspector disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-10-16 09:49 PDT by Philippe Normand
Modified: 2018-10-16 10:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.88 KB, patch)
2018-10-16 10:03 PDT, Philippe Normand 		mcatanzaro: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2018-10-16 09:49:40 PDT 
build-webkit --gtk --cmakeargs="-DENABLE_REMOTE_INSPECTOR=OFF"

In file included from ../../Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:35:
../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:115: error: ‘RemoteInspector’ in namespace ‘Inspector’ does not name a type
 WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&);
                                                                                                                   ^~~~~~~~~~~~~~~
In file included from ../../Source/WebKit/UIProcess/API/glib/WebKitWebContext.cpp:35:
../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:138: error: expected unqualified-id before ‘::’ token
 WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&);
                                                                                                                                          ^~
../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:138: error: expected ‘)’ before ‘::’ token
 WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&);
                                                       ~                                                                                  ^~
                                                                                                                                          )
../../Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h:27:138: error: expected initializer before ‘::’ token
 WebKitAutomationSession* webkitAutomationSessionCreate(WebKitWebContext*, const char* sessionID, const Inspector::RemoteInspector::Client::SessionCapabilities&);
                                                                                                                                          ^~
[1562/1986] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/WebKit/unified-sources/UnifiedSource30.cpp.o
Comment 1 Philippe Normand 2018-10-16 10:03:48 PDT 
Created attachment 352468 [details]
Patch
Comment 2 EWS Watchlist 2018-10-16 10:05:41 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Philippe Normand 2018-10-16 10:54:27 PDT 
Committed r237191: <https://trac.webkit.org/changeset/237191>