Bug 190622 - AX: Certain tags should identify their context to iOS API
Summary: AX: Certain tags should identify their context to iOS API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: chris fleizach
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-16 09:29 PDT by chris fleizach
Modified: 2018-10-17 10:52 PDT (History)
10 users (show)

See Also:

Attachments
patch (7.04 KB, patch)
2018-10-16 09:33 PDT, chris fleizach 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (3.36 MB, application/zip)
2018-10-16 11:18 PDT, EWS Watchlist 		no flags Details
patch (7.36 KB, patch)
2018-10-16 11:59 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
patch (8.25 KB, patch)
2018-10-16 12:01 PDT, chris fleizach 		ews-watchlist: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.31 MB, application/zip)
2018-10-16 17:22 PDT, EWS Watchlist 		no flags Details
patch (8.27 KB, patch)
2018-10-16 17:25 PDT, chris fleizach 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description chris fleizach 2018-10-16 09:29:21 PDT 
Certain tags like <Code> can convey important context to screen readers. Use iOS API to convey that information
Comment 1 Radar WebKit Bug Importer 2018-10-16 09:29:38 PDT 
<rdar://problem/45308194>
Comment 2 chris fleizach 2018-10-16 09:33:49 PDT 
Created attachment 352462 [details]
patch
Comment 3 EWS Watchlist 2018-10-16 11:18:41 PDT 
Comment on attachment 352462 [details]
patch

Attachment 352462 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9623410

New failing tests:
accessibility/ios-simulator/text-context-attributes.html
Comment 4 EWS Watchlist 2018-10-16 11:18:42 PDT 
Created attachment 352476 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 5 chris fleizach 2018-10-16 11:59:18 PDT 
Created attachment 352484 [details]
patch
Comment 6 chris fleizach 2018-10-16 12:01:09 PDT 
Created attachment 352485 [details]
patch
Comment 7 EWS Watchlist 2018-10-16 17:22:40 PDT 
Comment on attachment 352485 [details]
patch

Attachment 352485 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/9628111

New failing tests:
accessibility/ios-simulator/text-context-attributes.html
Comment 8 EWS Watchlist 2018-10-16 17:22:42 PDT 
Created attachment 352524 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.13.6
Comment 9 chris fleizach 2018-10-16 17:25:11 PDT 
Created attachment 352525 [details]
patch
Comment 10 WebKit Commit Bot 2018-10-17 10:52:23 PDT 
Comment on attachment 352525 [details]
patch

Clearing flags on attachment: 352525

Committed r237225: <https://trac.webkit.org/changeset/237225>
Comment 11 WebKit Commit Bot 2018-10-17 10:52:25 PDT 
All reviewed patches have been landed.  Closing bug.