Bug 190613 - Test imported/blink/fast/forms/datalist/slider-appearance-with-ticks-crash.html fails
Summary: Test imported/blink/fast/forms/datalist/slider-appearance-with-ticks-crash.ht...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
: 208315 (view as bug list)
Depends on:
Blocks:
 
Reported: 2018-10-15 19:18 PDT by Wenson Hsieh
Modified: 2020-03-17 17:32 PDT (History)
11 users (show)

See Also:


Attachments
Patch (3.36 KB, patch)
2020-02-27 06:12 PST, Carlos Garcia Campos
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2018-10-15 19:18:17 PDT
Support rendering tick marks for range inputs with datalists
Comment 1 Carlos Garcia Campos 2020-02-27 06:08:17 PST
This is already supported, I can see the tick marks in Safari. However, the test imported/blink/fast/forms/datalist/slider-appearance-with-ticks-crash.html is failing because we are not checking the input is actually a range control in RenderTheme::paintSliderTicks(). Since this is the bug associated with the test in the expectations, I'll reuse it to fix the test.
Comment 2 Carlos Garcia Campos 2020-02-27 06:12:10 PST
Created attachment 391852 [details]
Patch
Comment 3 Carlos Garcia Campos 2020-02-28 00:48:15 PST
Committed r257623: <https://trac.webkit.org/changeset/257623>
Comment 4 Radar WebKit Bug Importer 2020-02-28 00:49:14 PST
<rdar://problem/59880405>
Comment 5 Ryosuke Niwa 2020-03-17 17:32:50 PDT
*** Bug 208315 has been marked as a duplicate of this bug. ***