Bug 190610 - Modernize BackForwardClient.h
Summary: Modernize BackForwardClient.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-15 16:43 PDT by Alex Christensen
Modified: 2018-10-16 08:35 PDT (History)
3 users (show)

See Also:

Attachments
Patch (29.06 KB, patch)
2018-10-15 16:44 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (32.30 KB, patch)
2018-10-15 17:11 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-10-15 16:43:55 PDT 
Modernize BackForwardClient.h
Comment 1 Alex Christensen 2018-10-15 16:44:35 PDT 
Created attachment 352404 [details]
Patch
Comment 2 Chris Dumez 2018-10-15 16:47:38 PDT 
Comment on attachment 352404 [details]
Patch

r=me if the bots are happy.
Comment 3 Alex Christensen 2018-10-15 17:11:23 PDT 
Created attachment 352408 [details]
Patch
Comment 4 Alex Christensen 2018-10-15 17:15:03 PDT 
Windows EWS is too slow.  I'll watch the bots.
Comment 5 Alex Christensen 2018-10-15 17:19:10 PDT 
https://trac.webkit.org/changeset/237157/webkit
Comment 6 Radar WebKit Bug Importer 2018-10-15 17:20:28 PDT 
<rdar://problem/45290681>
Comment 7 Don Olmstead 2018-10-15 17:53:55 PDT 
(In reply to Alex Christensen from comment #4)
> Windows EWS is too slow.  I'll watch the bots.

WinCairo didn't like this change either.
Comment 8 Alex Christensen 2018-10-16 08:35:49 PDT 
I fixed the build last night.