Bug 190608 - Add stub implementation for accessibility objects
Summary: Add stub implementation for accessibility objects
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on: 190612
Blocks: 189418
  Show dependency tree / graph
 
Reported: 2018-10-15 15:44 PDT by Don Olmstead
Modified: 2018-10-16 10:20 PDT (History)
14 users (show)

See Also:

Attachments
Patch (9.16 KB, patch)
2018-10-15 16:12 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2018-10-15 15:44:40 PDT 
AccessibilityObjectWPE and AXObjectCacheWPE are just empty implementations
Comment 1 Don Olmstead 2018-10-15 16:12:40 PDT 
Created attachment 352397 [details]
Patch
Comment 2 Nan Wang 2018-10-15 17:26:44 PDT 
Comment on attachment 352397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352397&action=review

> Source/WebCore/accessibility/AXObjectCache.cpp:109
> +#if !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN))

Should wrap this into something for less confusion?
!(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN))
Basically this is HAVE_ACCESSIBILITY minus PLATFORM(WPE)?
Comment 3 Don Olmstead 2018-10-15 17:45:29 PDT 
(In reply to Nan Wang from comment #2)
> Comment on attachment 352397 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=352397&action=review
> 
> > Source/WebCore/accessibility/AXObjectCache.cpp:109
> > +#if !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN))
> 
> Should wrap this into something for less confusion?
> !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN))
> Basically this is HAVE_ACCESSIBILITY minus PLATFORM(WPE)?

I was more into having None implementations of things but rniwa wanted it more like this.
Comment 4 WebKit Commit Bot 2018-10-15 17:46:45 PDT 
Comment on attachment 352397 [details]
Patch

Clearing flags on attachment: 352397

Committed r237162: <https://trac.webkit.org/changeset/237162>
Comment 5 WebKit Commit Bot 2018-10-15 17:46:47 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2018-10-15 17:47:32 PDT 
<rdar://problem/45291448>
Comment 7 WebKit Commit Bot 2018-10-15 18:12:24 PDT 
Re-opened since this is blocked by bug 190612
Comment 8 Alex Christensen 2018-10-15 18:18:47 PDT 
Comment on attachment 352397 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352397&action=review

>>> Source/WebCore/accessibility/AXObjectCache.cpp:109
>>> +#if !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN))
>> 
>> Should wrap this into something for less confusion?
>> !(PLATFORM(IOS) || PLATFORM(MAC) || PLATFORM(GTK) || PLATFORM(WIN))
>> Basically this is HAVE_ACCESSIBILITY minus PLATFORM(WPE)?
> 
> I was more into having None implementations of things but rniwa wanted it more like this.

PLATFORM(IOS) || PLATFORM(MAC) == PLATFORM(COCOA)
I also think this looks like a mess.  Why not HAVE(ACCESSIBILITY)?
Comment 9 Ryosuke Niwa 2018-10-15 21:45:03 PDT 
Yeah, let's add HAVE_ACCESSIBILITY or ENABLE_ACCESSIBILITY.
Comment 10 Michael Catanzaro 2018-10-16 10:20:44 PDT 
There is already ENABLE_ACCESSIBILITY, so let's use that.