Bug 190603 – Support RTCConfiguration.certificates

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Now that we have generateCertificate, let's allow RTCPeerConnection to use these.

[youenn fablet]

Created attachment 352384 [details]
Patch

[youenn fablet]

Created attachment 352393 [details]
Patch

[Eric Carlson]

Comment on attachment 352393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=352393&action=review

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:303
> +            exception = Exception { InvalidAccessError, "Certificate is expired"_s };

Nit: "Certificate has expired" would be better.

> Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:324
>          return Exception { InvalidAccessError, "Bad Configuration Parameters" };

Nit: maybe "Invalid configuration parameters"?

[youenn fablet]

Thanks for the review.

> > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:303
> > +            exception = Exception { InvalidAccessError, "Certificate is expired"_s };
> 
> Nit: "Certificate has expired" would be better.

OK

> > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:324
> >          return Exception { InvalidAccessError, "Bad Configuration Parameters" };
> 
> Nit: maybe "Invalid configuration parameters"?

Will do in another patch since that might need rebasing some other tests.

[youenn fablet]

Created attachment 352481 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 352481 [details]
Patch for landing

Clearing flags on attachment: 352481

Committed r237202: <https://trac.webkit.org/changeset/237202>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/45317733>