Now that we have generateCertificate, let's allow RTCPeerConnection to use these.
Created attachment 352384 [details] Patch
Created attachment 352393 [details] Patch
Comment on attachment 352393 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=352393&action=review > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:303 > + exception = Exception { InvalidAccessError, "Certificate is expired"_s }; Nit: "Certificate has expired" would be better. > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:324 > return Exception { InvalidAccessError, "Bad Configuration Parameters" }; Nit: maybe "Invalid configuration parameters"?
Thanks for the review. > > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:303 > > + exception = Exception { InvalidAccessError, "Certificate is expired"_s }; > > Nit: "Certificate has expired" would be better. OK > > Source/WebCore/Modules/mediastream/RTCPeerConnection.cpp:324 > > return Exception { InvalidAccessError, "Bad Configuration Parameters" }; > > Nit: maybe "Invalid configuration parameters"? Will do in another patch since that might need rebasing some other tests.
Created attachment 352481 [details] Patch for landing
Comment on attachment 352481 [details] Patch for landing Clearing flags on attachment: 352481 Committed r237202: <https://trac.webkit.org/changeset/237202>
All reviewed patches have been landed. Closing bug.
<rdar://problem/45317733>