Bug 190600 - Remove unused parameters of WebPageGroupData
Summary: Remove unused parameters of WebPageGroupData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2018-10-15 13:57 PDT by Alex Christensen
Modified: 2018-10-15 18:13 PDT (History)
4 users (show)

See Also:

Attachments
Patch (10.61 KB, patch)
2018-10-15 13:58 PDT, Alex Christensen 		cdumez: review+
Details | Formatted Diff | Diff
Build fix (3.49 KB, patch)
2018-10-15 17:43 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Build fix (2.43 KB, patch)
2018-10-15 17:52 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2018-10-15 13:57:22 PDT 
Remove unused parameters of WebPageGroupData
Comment 1 Alex Christensen 2018-10-15 13:58:14 PDT 
Created attachment 352373 [details]
Patch
Comment 2 Chris Dumez 2018-10-15 14:07:12 PDT 
Comment on attachment 352373 [details]
Patch

r=me if the bots are happy.
Comment 3 Alex Christensen 2018-10-15 14:34:06 PDT 
http://trac.webkit.org/r237146
Comment 4 Radar WebKit Bug Importer 2018-10-15 14:35:37 PDT 
<rdar://problem/45284661>
Comment 5 Don Olmstead 2018-10-15 17:31:44 PDT 
WinCairo bot was not happy with this one.
Comment 6 Alex Christensen 2018-10-15 17:32:35 PDT 
I'll take a look.
Comment 7 Alex Christensen 2018-10-15 17:39:21 PDT 
https://trac.webkit.org/changeset/237161/webkit
Could WinCairo stop using the entire concept of PageGroups?  It's a legacy concept that we're trying to remove, so a new port should not have it.
Comment 8 Don Olmstead 2018-10-15 17:41:09 PDT 
(In reply to Alex Christensen from comment #7)
> https://trac.webkit.org/changeset/237161/webkit
> Could WinCairo stop using the entire concept of PageGroups?  It's a legacy
> concept that we're trying to remove, so a new port should not have it.

Sure. GTK ports were also affected though.

You want to get stuff to green or do you want to start ripping out PageGroups?
Comment 9 Alex Christensen 2018-10-15 17:42:03 PDT 
Get stuff to green for now. We unfortunately can't remove PageGroups right now because they're used by an Apple-internal client.
Comment 10 Don Olmstead 2018-10-15 17:43:04 PDT 
Created attachment 352412 [details]
Build fix

Here's a build fix that should work. Your call if you want to land it.
Comment 11 Don Olmstead 2018-10-15 17:52:14 PDT 
Created attachment 352414 [details]
Build fix

Now with GTK
Comment 12 Don Olmstead 2018-10-15 18:07:23 PDT 
Ok so the GTK bots are borked because of that BUBBLE_WRAP dependency they added. Michael this patch work for you in GTK? I don't have a GTK build.
Comment 13 Alex Christensen 2018-10-15 18:13:45 PDT 
Fixed GTK in 237165
Fixed API tests in r237167